Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 12210134: Define _AMD64_, MP_CHAR_STORE_SLOW, and MP_IS_LITTLE_ENDIAN (Closed)

Created:
7 years, 10 months ago by wtc
Modified:
7 years, 10 months ago
Reviewers:
jschuh, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Define _AMD64_, MP_CHAR_STORE_SLOW, and MP_IS_LITTLE_ENDIAN for 64-bit Windows builds. This matches the upstream NSS build system. R=jschuh@chromium.org,rsleevi@chromium.org BUG=167951 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M nss.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
The upstream NSS build system defines these macros at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/coreconf/WIN32.mk&rev=1.45&mark=183-185#183 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/freebl/Makefile&rev=1.127&mark=118-119,139,141#118 See also Linux x86-64, ...
7 years, 10 months ago (2013-02-12 04:34:43 UTC) #1
Ryan Sleevi
LGTM. Note: These are also addressed in https://codereview.chromium.org/11738002/diff/2002/nss.gyp , although I haven't landed that per ...
7 years, 10 months ago (2013-02-12 18:20:39 UTC) #2
jschuh
lgtm
7 years, 10 months ago (2013-02-12 18:22:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/12210134/1
7 years, 10 months ago (2013-02-14 23:45:22 UTC) #4
commit-bot: I haz the power
Change committed as 182578
7 years, 10 months ago (2013-02-14 23:45:37 UTC) #5
wtc
7 years, 10 months ago (2013-02-14 23:49:17 UTC) #6
Message was sent while issue was closed.
On 2013/02/12 18:20:39, Ryan Sleevi wrote:
>
> Note: These are also addressed in
> https://codereview.chromium.org/11738002/diff/2002/nss.gyp ,

Thanks. I knew I suggested these changes to you when I reviewed
that CL.

I was in this code again recently when I added the ARM assembly
code to iOS and needed to study these freebl configuration macros,
so I wrote this CL in that process.

Powered by Google App Engine
This is Rietveld 408576698