Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 12210132: Enable compositor frame message. (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jamie.strandboge, aruslan, Yaron, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable compositor frame message. The cause of the flaky tests this was causing is now better-understood and we can re-enable this (the flaky tests are still disabled). Note that this flag is also enabled by default on phones from Java, so we should turn it on here to get the behavior everywhere and stop needing to support the old path. NOTRY=true BUG=161945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aelias_OOO_until_Jul13
Hi Ted, Let's turn this on everywhere, the current way we toggle it only in ...
7 years, 10 months ago (2013-02-12 03:56:47 UTC) #1
Ted C
lgtm
7 years, 10 months ago (2013-02-12 15:32:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12210132/1
7 years, 10 months ago (2013-02-12 20:21:45 UTC) #3
commit-bot: I haz the power
Change committed as 181994
7 years, 10 months ago (2013-02-12 20:25:23 UTC) #4
boliu
This caused some downstream webview cts tests to fail. I don't see any obvious pattern ...
7 years, 10 months ago (2013-02-12 23:58:49 UTC) #5
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-13 00:00:40 UTC) #6
Message was sent while issue was closed.
On 2013/02/12 23:58:49, boliu wrote:
> This caused some downstream webview cts tests to fail. I don't see any obvious
> pattern to the fail tests though.

We have seen this for other tests and it was because there was a race condition
involving pageScaleFactor.  This message sends it up much faster than before. 
Please disable and file a bug assigned to aruslan@, he's tackling the tests.

Powered by Google App Engine
This is Rietveld 408576698