Issue 12210113: Check existence of chrome.runtime APIs using __lookupGetter__ to avoid throwing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210113: Check existence of chrome.runtime APIs using lookupGetter to avoid throwing (Closed)

Created:
7 years, 10 months ago by not at google - send to devlin

Modified:
7 years, 10 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Check existence of chrome.runtime APIs using __lookupGetter__ to avoid throwing exceptions, which devtools apparently pick up despite surrounding in try/catch. BUG=174960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181882

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	chrome/renderer/resources/extensions/extension_custom_bindings.js	View		1 chunk	+6 lines, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12210113/1

7 years, 10 months ago (2013-02-12 01:29:16 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 10 months ago (2013-02-12 01:59:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12210113/1

7 years, 10 months ago (2013-02-12 02:08:50 UTC) #5

Message was sent while issue was closed.

Change committed as 181882