cc: Disable RenderSurface caching.

cc: Disable RenderSurface caching.

Surface caching is currently broken if any layers in the surface do not
draw themselves fully within the bounds of the surface for any reason
other than being occluded. This includes:
1) Being at non-ideal scale.
2) Being checkerboarded.
3) Missing a texture resource.
4) Having visibleContentRect clipped by something outside the surface.

This disables the feature entirely.

R=jamesr,vangelis
BUG=170713
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182136

[vangelis, 2013-02-11 05:58:19]

LGTM

Thanks!

[commit-bot: I haz the power, 2013-02-11 08:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12210077/2001

[commit-bot: I haz the power, 2013-02-11 08:20:26]

Failed to apply patch for cc/layer_tree_settings.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/layer_tree_settings.cc
  Hunk #2 FAILED at 63.
  1 out of 2 hunks FAILED -- saving rejects to file
cc/layer_tree_settings.cc.rej

Patch:       cc/layer_tree_settings.cc
Index: cc/layer_tree_settings.cc
diff --git a/cc/layer_tree_settings.cc b/cc/layer_tree_settings.cc
index
f35094316a02e5262cf3820c210ccd4e95be02d1..53aeca9244558b800b53edbb42d221d2a0ab7be3
100644
--- a/cc/layer_tree_settings.cc
+++ b/cc/layer_tree_settings.cc
@@ -20,6 +20,7 @@ LayerTreeSettings::LayerTreeSettings()
     , renderVSyncEnabled(true)
     , perTilePaintingEnabled(false)
     , partialSwapEnabled(false)
+    , cacheRenderPassContents(true)
     , rightAlignedSchedulingEnabled(false)
     , acceleratedAnimationEnabled(true)
     , pageScalePinchZoomEnabled(false)
@@ -62,6 +63,9 @@ LayerTreeSettings::LayerTreeSettings()
     useLinearFadeScrollbarAnimator = true;
 #endif
 
+    // TODO(danakj): Renable surface caching when we can do it more realiably.
crbug.com/170713
+    cacheRenderPassContents = false;
+
     initialDebugState.showPropertyChangedRects =
CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kShowPropertyChangedRects);
     initialDebugState.showSurfaceDamageRects =
CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kShowSurfaceDamageRects);
     initialDebugState.showScreenSpaceRects =
CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kShowScreenSpaceRects);

[commit-bot: I haz the power, 2013-02-11 18:16:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12210077/9001

[commit-bot: I haz the power, 2013-02-11 20:02:32]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-02-11 21:00:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12210077/9001

[commit-bot: I haz the power, 2013-02-12 00:08:06]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[Vangelis Kokkevis, 2013-02-13 01:17:34]

On 2013/02/12 00:08:06, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_chromeos for step(s) browser_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Dana, are these failures legit, or should simply dcommit it? It would be great
to merge the fix back to 25..

[danakj, 2013-02-13 01:18:34]

On 2013/02/13 01:17:34, Vangelis Kokkevis wrote:
> On 2013/02/12 00:08:06, I haz the power (commit-bot) wrote:
> > Retried try job too often on linux_chromeos for step(s) browser_tests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
> 
> Dana, are these failures legit, or should simply dcommit it? It would be great
> to merge the fix back to 25..

Oh didnt see this fall out of the CQ. I doubt they are legit, I'll try once
more.

[commit-bot: I haz the power, 2013-02-13 01:22:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12210077/9001

[commit-bot: I haz the power, 2013-02-13 06:11:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12210077/9001

[commit-bot: I haz the power, 2013-02-13 06:17:22]

Change committed as 182136