Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 12210036: Use 'pm clear' to clear application state. (Closed)

Created:
7 years, 10 months ago by aberent
Modified:
7 years, 10 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use 'pm clear' to clear application state. This is the Android supported way, and avoids needing root privileges Note, however, that we have to check that the package exists before calling pm clear, since pm clear on a package that doesn't exist may never return. See also the discussion on https://codereview.chromium.org/12094041/ BUG=169011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183503

Patch Set 1 #

Patch Set 2 : Check package exists before calling pm clear #

Patch Set 3 : Check package exists before calling pm clear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/android/pylib/android_commands.py View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
aberent
7 years, 10 months ago (2013-02-06 15:55:52 UTC) #1
bulach
lgtm, thansk!
7 years, 10 months ago (2013-02-06 15:58:10 UTC) #2
John Knottenbelt
lgtm
7 years, 10 months ago (2013-02-06 16:09:39 UTC) #3
Isaac (away)
lgtm but looks like there's a issue with package name...
7 years, 10 months ago (2013-02-07 05:44:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/12210036/1
7 years, 10 months ago (2013-02-07 09:58:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/12210036/1
7 years, 10 months ago (2013-02-07 17:07:33 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 10 months ago (2013-02-08 02:17:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/12210036/1
7 years, 10 months ago (2013-02-19 15:31:27 UTC) #8
bulach
lgtm, thanks!
7 years, 10 months ago (2013-02-19 18:29:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/12210036/18003
7 years, 10 months ago (2013-02-19 19:47:53 UTC) #10
anagy4698
Ejha, az összes fontos üzenetet elolvasta a beérkezett levelek közül! 2013/2/19 <commit-bot@chromium.org> > CQ is ...
7 years, 10 months ago (2013-02-19 20:21:22 UTC) #11
commit-bot: I haz the power
List of reviewers changed. anagy4698@gmail.com did a drive-by without LGTM'ing!
7 years, 10 months ago (2013-02-20 12:08:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/12210036/18003
7 years, 10 months ago (2013-02-20 12:10:34 UTC) #13
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 13:26:29 UTC) #14
Message was sent while issue was closed.
Change committed as 183503

Powered by Google App Engine
This is Rietveld 408576698