Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 12210035: Use non-deprecated versions of v8::Persistent::New/Dispose. (Closed)

Created:
7 years, 10 months ago by Sven Panne
Modified:
7 years, 10 months ago
CC:
chromium-reviews, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Use non-deprecated versions of v8::Persistent::New/Dispose. BUG=v8::2487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.cc View 4 chunks +14 lines, -8 lines 0 comments Download
M content/renderer/v8_value_converter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Sven Panne
Hopefully picked the right reviewer. :-) PTAL...
7 years, 10 months ago (2013-02-06 14:51:51 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 10 months ago (2013-02-07 12:22:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-07 12:40:06 UTC) #3
commit-bot: I haz the power
Presubmit check for 12210035-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-07 12:40:08 UTC) #4
Sven Panne
Adding jam@ as a reviewer, apatrick@'s ping TTL expired... ;-) This is a purely mechanical ...
7 years, 10 months ago (2013-02-08 08:08:24 UTC) #5
jam
On 2013/02/08 08:08:24, Sven Panne wrote: > Adding jam@ as a reviewer, apatrick@'s ping TTL ...
7 years, 10 months ago (2013-02-08 17:50:35 UTC) #6
Sven Panne
Adding Ken. PTAL...
7 years, 10 months ago (2013-02-11 07:40:30 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
7 years, 10 months ago (2013-02-11 22:00:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-12 07:14:51 UTC) #9
commit-bot: I haz the power
Presubmit check for 12210035-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-12 07:14:54 UTC) #10
Sven Panne
Adding James to review the tiny content/renderer part... :-/
7 years, 10 months ago (2013-02-12 07:23:11 UTC) #11
jamesr
lgtm
7 years, 10 months ago (2013-02-12 07:28:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-12 07:43:18 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98583
7 years, 10 months ago (2013-02-12 08:38:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-12 13:31:09 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98715
7 years, 10 months ago (2013-02-12 14:21:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-12 14:39:57 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98764
7 years, 10 months ago (2013-02-12 16:17:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
7 years, 10 months ago (2013-02-12 16:21:19 UTC) #19
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 19:17:24 UTC) #20
Message was sent while issue was closed.
Change committed as 181970

Powered by Google App Engine
This is Rietveld 408576698