|
|
Created:
7 years, 10 months ago by Sven Panne Modified:
7 years, 10 months ago CC:
chromium-reviews, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionUse non-deprecated versions of v8::Persistent::New/Dispose.
BUG=v8::2487
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181970
Patch Set 1 #
Messages
Total messages: 20 (0 generated)
Hopefully picked the right reviewer. :-) PTAL...
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Presubmit check for 12210035-1 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Missing LGTM from an OWNER for files in these directories: content/renderer/gpu content/renderer
Adding jam@ as a reviewer, apatrick@'s ping TTL expired... ;-) This is a purely mechanical change, replacing a handful of deprecated v8 API calls with their new equivalents.
On 2013/02/08 08:08:24, Sven Panne wrote: > Adding jam@ as a reviewer, apatrick@'s ping TTL expired... ;-) > > This is a purely mechanical change, replacing a handful of deprecated v8 API > calls with their new equivalents. i'm not familiar with this code. please get someone from content/renderer/gpu/owners to look at this. once they do, you have my rubberstamp for the test.
Adding Ken. PTAL...
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Presubmit check for 12210035-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit commit checks ... Running /b/commit-queue/workdir/chromium/PRESUBMIT.py ** Presubmit ERRORS ** Missing LGTM from an OWNER for files in these directories: content/renderer
Adding James to review the tiny content/renderer part... :-/
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/12210035/1
Message was sent while issue was closed.
Change committed as 181970 |