Issue 12210033: Simplify secure API functions workaround for MinGW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12210033: Simplify secure API functions workaround for MinGW (Closed)

Created:
7 years, 10 months ago by Net147

Modified:
7 years, 10 months ago

Reviewers:
ulan, Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Simplify secure API functions workaround for MinGW If MINGW_HAS_SECURE_API is defined, the definitions of localtime_s, fopen_s, _vsnprintf_s, strncpy_s had to be renamed using #define so they would not conflict with definitions in the standard headers. A simpler way to handle this is to undefine MINGW_HAS_SECURE_API before including the standard headers. Contributed by net147@gmail.com BUGS= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13607

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	src/platform-win32.cc	View		3 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed manually as r13607 (presubmit successful).

Expand Messages | Collapse Messages