Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12210030: Linux/ChromeOS Chromium style checker cleanup, content/ edition. (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, benjhayden+dwatch_chromium.org, rouslan+watch_chromium.org, cbentzel+watch_chromium.org, vsevik, gavinp+disk_chromium.org, aboxhall+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, groby+watch_chromium.org, creis+watch_chromium.org, rdsmith+dwatch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, yurys, davidbarr+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, smckay+watch_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Linux/ChromeOS Chromium style checker cleanup, content/ edition. Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181822

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -255 lines) Patch
M content/app/content_main_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/device_orientation_browsertest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/device_orientation/provider_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_unittest.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_id_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/device_data_provider_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/gps_location_provider_unittest_linux.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/mock_location_provider.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_blacklist_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_crash_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_memory_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/webgl_conformance_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M content/browser/media/webrtc_internals_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_printing_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/endpointer/endpointer_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tracing/trace_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/fileapi/webfilewriter_impl.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M content/common/resource_dispatcher.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M content/common/resource_dispatcher_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/socket_stream_dispatcher.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_info_collector_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_file_error_injector.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/web_contents_tester.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/all_rendering_benchmarks.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/gpu/input_event_filter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dependency_factory_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 1 1 chunk +11 lines, -11 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M content/renderer/plugin_channel_host.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_clipboard_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/web_ui_extension.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 4 chunks +14 lines, -12 lines 0 comments Download
M content/test/gpu/gpu_test_config_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_test_expectations_parser_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/net/url_request_prepackaged_interceptor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
avi: Please consider rubberstamping. This is an automated fixup that was generated by our Clang ...
7 years, 10 months ago (2013-02-06 05:56:33 UTC) #1
Ryan Sleevi
brettw: Since you've been great at rubberstamping, mind rubberstamping this last one? This should enable ...
7 years, 10 months ago (2013-02-09 02:50:49 UTC) #2
brettw
rubberstamp lgtm
7 years, 10 months ago (2013-02-11 20:48:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12210030/19001
7 years, 10 months ago (2013-02-11 23:52:51 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 02:08:05 UTC) #5
Message was sent while issue was closed. 
Change committed as 181822

Powered by Google App Engine
This is Rietveld 408576698