Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 12210023: Security unittests: add more compiler barriers (Closed)

Created:
7 years, 10 months ago by jln (very slow on Chromium)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Security unittests: add more compiler barriers Add more compiler barriers to prevent the compiler from optimizing out calls to the very function we're testing. This makes SecurityTest* pass in a Clang release build. BUG=174452 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180888

Patch Set 1 #

Total comments: 2

Patch Set 2 : Cosmetic change. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M base/security_unittest.cc View 1 2 5 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jln (very slow on Chromium)
Jim, do you mind taking a quick look at this tiny CL ? This adds ...
7 years, 10 months ago (2013-02-05 21:39:32 UTC) #1
awong
https://codereview.chromium.org/12210023/diff/1/base/security_unittest.cc File base/security_unittest.cc (right): https://codereview.chromium.org/12210023/diff/1/base/security_unittest.cc#newcode75 base/security_unittest.cc:75: ASSERT_TRUE(ptr == NULL); drive-by nit: this would be cleaner ...
7 years, 10 months ago (2013-02-05 22:42:22 UTC) #2
jar (doing other things)
Compiler barrier seems plausible... so LGTM with nit suggested by ajwong (probably meant to be ...
7 years, 10 months ago (2013-02-05 23:15:01 UTC) #3
jln (very slow on Chromium)
https://codereview.chromium.org/12210023/diff/1/base/security_unittest.cc File base/security_unittest.cc (right): https://codereview.chromium.org/12210023/diff/1/base/security_unittest.cc#newcode75 base/security_unittest.cc:75: ASSERT_TRUE(ptr == NULL); On 2013/02/05 22:42:22, awong wrote: > ...
7 years, 10 months ago (2013-02-06 00:05:01 UTC) #4
awong
LGTM
7 years, 10 months ago (2013-02-06 00:06:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12210023/5002
7 years, 10 months ago (2013-02-06 03:11:58 UTC) #6
commit-bot: I haz the power
Failed to apply patch for base/security_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-06 03:12:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12210023/5003
7 years, 10 months ago (2013-02-06 03:21:57 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 03:23:51 UTC) #9
Message was sent while issue was closed.
Change committed as 180888

Powered by Google App Engine
This is Rietveld 408576698