Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4954)

Unified Diff: chrome/browser/sync_file_system/drive_file_sync_client.cc

Issue 12209115: Sync FileSystem: disable etag match on duplication recovery. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment, rename deletion function Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_file_sync_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_file_sync_client.cc
diff --git a/chrome/browser/sync_file_system/drive_file_sync_client.cc b/chrome/browser/sync_file_system/drive_file_sync_client.cc
index 955c8dae82e588b48651076e50359c545cfe0d54..6d6895459ff98f4b1389616ae5756f55a62af736 100644
--- a/chrome/browser/sync_file_system/drive_file_sync_client.cc
+++ b/chrome/browser/sync_file_system/drive_file_sync_client.cc
@@ -824,9 +824,9 @@ void DriveFileSyncClient::DidListEntriesToEnsureUniqueness(
entries.back() = NULL;
entries.get().pop_back();
- DeleteEntries(entries.Pass(),
- base::Bind(&EntryAdapter, base::Passed(&earliest_entry),
- callback));
+ DeleteEntriesForEnsuringTitleUniqueness(
+ entries.Pass(),
+ base::Bind(&EntryAdapter, base::Passed(&earliest_entry), callback));
return;
}
@@ -837,7 +837,7 @@ void DriveFileSyncClient::DidListEntriesToEnsureUniqueness(
callback.Run(google_apis::HTTP_FOUND, entry.Pass());
}
-void DriveFileSyncClient::DeleteEntries(
+void DriveFileSyncClient::DeleteEntriesForEnsuringTitleUniqueness(
ScopedVector<google_apis::ResourceEntry> entries,
const GDataErrorCallback& callback) {
DCHECK(CalledOnValidThread());
@@ -852,14 +852,17 @@ void DriveFileSyncClient::DeleteEntries(
entries.back() = NULL;
entries.get().pop_back();
+ // We don't care conflicts here as other clients may be also deleting this
+ // file, so passing an empty etag.
drive_service_->DeleteResource(
entry->resource_id(),
- entry->etag(),
- base::Bind(&DriveFileSyncClient::DidDeleteEntry, AsWeakPtr(),
- base::Passed(&entries), callback));
+ std::string(), // empty etag
+ base::Bind(
+ &DriveFileSyncClient::DidDeleteEntriesForEnsuringTitleUniqueness,
+ AsWeakPtr(), base::Passed(&entries), callback));
}
-void DriveFileSyncClient::DidDeleteEntry(
+void DriveFileSyncClient::DidDeleteEntriesForEnsuringTitleUniqueness(
ScopedVector<google_apis::ResourceEntry> entries,
const GDataErrorCallback& callback,
google_apis::GDataErrorCode error) {
@@ -873,7 +876,7 @@ void DriveFileSyncClient::DidDeleteEntry(
}
DVLOG(2) << "Deletion completed";
- DeleteEntries(entries.Pass(), callback);
+ DeleteEntriesForEnsuringTitleUniqueness(entries.Pass(), callback);
}
} // namespace sync_file_system
« no previous file with comments | « chrome/browser/sync_file_system/drive_file_sync_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698