Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: ash/wm/workspace/workspace_cycler.cc

Issue 12209109: Switch ending workspace cycling to when the user lifts their fingers off the track pad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_cycler.cc
diff --git a/ash/wm/workspace/workspace_cycler.cc b/ash/wm/workspace/workspace_cycler.cc
index b4b8b254b3627d0f1b7368248343c5361761f857..5015fff092d2751c68333ac005200dbf8a121e1f 100644
--- a/ash/wm/workspace/workspace_cycler.cc
+++ b/ash/wm/workspace/workspace_cycler.cc
@@ -102,10 +102,7 @@ void WorkspaceCycler::OnEvent(ui::Event* event) {
}
void WorkspaceCycler::OnScrollEvent(ui::ScrollEvent* event) {
- // End cycling when the user taps after having cycled through workspaces.
- // TODO(pkotwicz): Use ui::ET_SCROLL_FLING_START instead to end cycling once
- // it works for three fingers. (http://crbug.com/170484)
- if (state_ != NOT_CYCLING && event->type() == ui::ET_SCROLL_FLING_CANCEL) {
+ if (state_ != NOT_CYCLING && event->type() == ui::ET_SCROLL_FLING_START) {
SetState(STOPPING_CYCLING);
event->StopPropagation();
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698