Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 12209109: Switch ending workspace cycling to when the user lifts their fingers off the track pad (Closed)

Created:
7 years, 10 months ago by pkotwicz
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, DaveMoore
Visibility:
Public.

Description

Switch ending workspace cycling to when the user lifts their fingers off the track pad Bug=None Test=Manual, see steps below. Test steps: 1) Start cycling using three fingers vertically on the track pad. 2) Ensure that lifting said fingers ends cycling. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M ash/wm/workspace/workspace_cycler.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
Scott, can you please take a look?
7 years, 10 months ago (2013-02-12 00:12:08 UTC) #1
sky
7 years, 10 months ago (2013-02-12 00:40:30 UTC) #2
sky
GAH! win-aura is not behaving LGTM
7 years, 10 months ago (2013-02-12 00:40:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/12209109/1
7 years, 10 months ago (2013-02-12 00:46:41 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 06:15:40 UTC) #5
Message was sent while issue was closed.
Change committed as 181877

Powered by Google App Engine
This is Rietveld 408576698