Intercept Inspector DOM.setFileInputFiles and grant read permissions to the

Fix naming of DevToolsAgentHostImpl::DipatchOnInspectorBackend (Dipatch -> Dispatch). Make it virtual and override in RenderViewDevToolsAgentHost.

Right now the overridden version just calls the parent method. Next CL will change this to allow for request interception and optional handling.
BUG=167100
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182361

[kkania, 2013-02-12 00:11:04]

In addition to the necessary changes, I've also renamed
DipatchOnInspectorBackend to DispatchOnInspectorBackend and fixed the forward
declaration order for RenderViewDevToolsAgentHost.

This grants permission to the renderer file-by-file and doesn't revoke it, even
if the method fails, or the next files aren't strings. I don't think we gain
anything by revoking it, but let me know.

[pfeldman, 2013-02-12 15:03:27]

https://codereview.chromium.org/12209107/diff/3008/content/browser/devtools/r...
File content/browser/devtools/render_view_devtools_agent_host.cc (right):

https://codereview.chromium.org/12209107/diff/3008/content/browser/devtools/r...
content/browser/devtools/render_view_devtools_agent_host.cc:162: if
(command->method() == "DOM.setFileInputFiles")
I think we could reuse DomainHandler from DevToolsBrowserTarget
(devtools_browser_target.h). It has a nice 

virtual scoped_ptr<DevToolsProtocol::Response> HandleCommand(
        DevToolsProtocol::Command* command);

interface that you could call into.

Take a look at how devtools_tracing_handler is extending it and registers its
handlers using DomainHandler::RegisterCommandHandler (it should have been
protected).

Here is what I would do:
1) Land this change with renames and empty DispatchOnInspectorBackend
2) Move DevToolsBrowserTarget::DomainHandler into DevToolsProtocol::Handler
(beside Command, Response and Notification)
3) Create a new RendererOverridesHandler : public DevToolsProtocol::Handler,
call into it from here. If it returns early response, use it, fall back to
standard path otherwise.
4) Put all overrides into that new RendererOverridesHandler

[kkania, 2013-02-12 17:54:20]

Changed this CL to fix naming, make it virtual, and override it in RVDTA that
just redirects to parent impl. You mentioned in your comment you wanted to leave
it 'empty', and I guess you mean just call parent class. Let me know if don't
want me to override it until the next CL.

[pfeldman, 2013-02-13 17:12:21]

lgtm

[commit-bot: I haz the power, 2013-02-13 17:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/12209107/6003

[commit-bot: I haz the power, 2013-02-13 19:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/12209107/6003

[commit-bot: I haz the power, 2013-02-14 00:59:16]

Change committed as 182361