Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 12209104: Fix crash when DecrementCapturerCount() makes a delayed WasHidden() call during WebContentsImpl dest (Closed)

Created:
7 years, 10 months ago by miu
Modified:
7 years, 10 months ago
Reviewers:
ncarter (slow), sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix crash when DecrementCapturerCount() makes a delayed WasHidden() call during WebContentsImpl destruction. Two parts: 1. WebContentsImpl::DecrementCapturerCount() will restore the true "WasHidden" status of the RenderWidgetHost once the counter reaches zero. However, DecrementCapturerCount() can be called [indirectly] from the WebContentsImpl destructor. In this case, it should not attempt to change/notify anything. 2. It's possible for ThumbnailTabHelper::WidgetHidden() to call ThumbnailTabHelper::UpdateThumbnailIfNecessary() with a NULL pointer. Added a NULL check. BUG=175275, 130097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181876

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
miu
Nick: PTAL. Ben: Need OWNERS approval for both files. Thanks, Yuri
7 years, 10 months ago (2013-02-11 23:47:07 UTC) #1
miu
s/ben/sky/ in reviewers list sky: Given you've looked at my original change recently, I think ...
7 years, 10 months ago (2013-02-11 23:56:33 UTC) #2
ncarter (slow)
lgtm LGTM
7 years, 10 months ago (2013-02-12 00:03:00 UTC) #3
sky
LGTM
7 years, 10 months ago (2013-02-12 00:39:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/12209104/4002
7 years, 10 months ago (2013-02-12 00:59:53 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 06:15:28 UTC) #6
Message was sent while issue was closed.
Change committed as 181876

Powered by Google App Engine
This is Rietveld 408576698