[NaCl SDK] make example Makefiles quiet by default

[NaCl SDK] make example Makefiles quiet by default

This is a port of some of the changes made to the common.mk
system when it was ported to support building nacltoons.

Also, change oshelpers "rm -f" so that is doesn't output
anything when it can't find files (this matches /bin/rm
behavior).

Also, remove redundant nmf build rules from host_vc.mk and
host_gcc.mk.

Also, add .mk files to exclusion list in top level
PRESUBMIT.py since they contain lines longer than 80 chars
and fixing this would make them harder to read.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181856

[binji, 2013-02-11 20:01:18]

I'd like to see this for all toolchains, not just nacl_gcc

[Sam Clegg, 2013-02-11 20:31:01]

Done.  PTAL.

[binji, 2013-02-11 20:46:07]

lgtm

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:106: RECURSIVE_TARGET?=all
is this for a different CL?

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:217: # the commend echoed is not the same
as the actual command executed.
sp: command

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:228: @echo "  $(1) $(2)" && $(3)
maybe a comment about what 1,2,3 are here?

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/host_gcc.mk:49: $(call LOG,CC,$$@,$(HOST_CXX) -o $$@
-c $$< -fPIC $(POSIX_FLAGS) $(2) $(LINUX_FLAGS))
CXX? I guess it doesn't really matter.

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/nacl_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:101: $(X86_LINK) -o $$@ $$(filter-out
$(4),$$^) -shared -m32 $$(LD_X86_32) $$(LD_FLAGS) $(foreach lib,$(3),-l$(lib))
here too?

[Sam Clegg, 2013-02-11 21:07:42]

Handle ar (lib) commands too.

Rename varialbe names from X86,X86 to X86_32,X86_64 for
consistency.

PTAL

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:217: # the commend echoed is not the same
as the actual command executed.
On 2013/02/11 20:46:07, binji wrote:
> sp: command

Done.

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:228: @echo "  $(1) $(2)" && $(3)
On 2013/02/11 20:46:07, binji wrote:
> maybe a comment about what 1,2,3 are here?

Done.

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/host_gcc.mk:49: $(call LOG,CC,$$@,$(HOST_CXX) -o $$@
-c $$< -fPIC $(POSIX_FLAGS) $(2) $(LINUX_FLAGS))
On 2013/02/11 20:46:07, binji wrote:
> CXX? I guess it doesn't really matter.

Done.

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
File native_client_sdk/src/tools/nacl_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4001/native_client_sdk/src/tool...
native_client_sdk/src/tools/nacl_gcc.mk:101: $(X86_LINK) -o $$@ $$(filter-out
$(4),$$^) -shared -m32 $$(LD_X86_32) $$(LD_FLAGS) $(foreach lib,$(3),-l$(lib))
On 2013/02/11 20:46:07, binji wrote:
> here too?

Done.

[noelallen1, 2013-02-11 23:02:44]

Move RECURSIVE into a different change.
Make sure -as-needed is correct for both host_gcc and nacl.
otherwise, LGTM

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:106: RECURSIVE_TARGET?=all
Separate change pls.

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
native_client_sdk/src/tools/host_gcc.mk:109: $(call LOG,LINK,$$@,$(HOST_LINK)
-shared -o $(1) $(2) $(foreach path,$(5),-L$(path)/$(OSNAME)_host)/$(CONFIG)
$(foreach lib,$(3),-l$(lib)) $(6))
as needed?

[Sam Clegg, 2013-02-11 23:07:14]

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
File native_client_sdk/src/tools/common.mk (right):

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
native_client_sdk/src/tools/common.mk:106: RECURSIVE_TARGET?=all
On 2013/02/11 23:02:44, noelallen1 wrote:
> Separate change pls.

Done.

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
File native_client_sdk/src/tools/host_gcc.mk (right):

https://codereview.chromium.org/12209097/diff/4002/native_client_sdk/src/tool...
native_client_sdk/src/tools/host_gcc.mk:109: $(call LOG,LINK,$$@,$(HOST_LINK)
-shared -o $(1) $(2) $(foreach path,$(5),-L$(path)/$(OSNAME)_host)/$(CONFIG)
$(foreach lib,$(3),-l$(lib)) $(6))
On 2013/02/11 23:02:44, noelallen1 wrote:
> as needed?

Done.

[commit-bot: I haz the power, 2013-02-11 23:10:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/12209097/10003

[commit-bot: I haz the power, 2013-02-11 23:10:41]

Presubmit check for 12209097-10003 failed and returned exit status 1.

INFO:root:Found 7 file(s).

testBadOrigFile (__main__.BadExtensionsTest) ... ok
testBadRejFile (__main__.BadExtensionsTest) ... ok
testGoodFiles (__main__.BadExtensionsTest) ... ok
testOnlyOwnersFiles (__main__.BadExtensionsTest) ... ok
testAlphabeticalOrderMismatch (__main__.IncludeOrderTest) ... ok
testCheckOnlyCFiles (__main__.IncludeOrderTest) ... ok
testConflictAdded1 (__main__.IncludeOrderTest) ... ok
testConflictAdded2 (__main__.IncludeOrderTest) ... ok
testIfElifElseEndif (__main__.IncludeOrderTest) ... ok
testOnlyNotifyOnCommit (__main__.IncludeOrderTest) ... ok
testOrderAlreadyWrong (__main__.IncludeOrderTest) ... ok
testSpecialFirstInclude1 (__main__.IncludeOrderTest) ... ok
testSpecialFirstInclude2 (__main__.IncludeOrderTest) ... ok
testSpecialFirstInclude3 (__main__.IncludeOrderTest) ... ok
testSpecialFirstInclude4 (__main__.IncludeOrderTest) ... ok
testSpecialFirstInclude5 (__main__.IncludeOrderTest) ... ok
testSysIncludes (__main__.IncludeOrderTest) ... ok
testSystemHeaderOrder (__main__.IncludeOrderTest) ... ok
testSystemHeaderOrderMismatch1 (__main__.IncludeOrderTest) ... ok
testSystemHeaderOrderMismatch2 (__main__.IncludeOrderTest) ... ok
testSystemHeaderOrderMismatch3 (__main__.IncludeOrderTest) ... ok
testUncheckableIncludes (__main__.IncludeOrderTest) ... ok
testTypicalConflict (__main__.VersionControlerConflictsTest) ... ok

----------------------------------------------------------------------
Ran 23 tests in 0.005s

OK
INFO:PRESUBMIT:Running pylint on: ['PRESUBMIT.py', 'src/test_all.py',
'src/project_templates/init_project_test.py',
'src/project_templates/init_project.py', 'src/build_tools/generate_notice.py',
'src/build_tools/update_sdktools.py', 'src/build_tools/test_sdk.py',
'src/build_tools/buildbot_run.py', 'src/build_tools/update_nacl_manifest.py',
'src/build_tools/nacl-mono-buildbot.py', 'src/build_tools/manifest_util.py',
'src/build_tools/make_rules.py', 'src/build_tools/__init__.py',
'src/build_tools/generate_index.py', 'src/build_tools/build_updater.py',
'src/build_tools/build_examples.py', 'src/build_tools/dsc2gyp.py',
'src/build_tools/nacl-mono-builder.py', 'src/build_tools/build_utils.py',
'src/build_tools/nacl-mono-archive.py', 'src/build_tools/generate_make.py',
'src/build_tools/make_simple.py', 'src/build_tools/buildbot_common.py',
'src/build_tools/build_sdk.py', 'src/build_tools/sdk_tools/set_nacl_env.py',
'src/build_tools/sdk_tools/config.py', 'src/build_tools/sdk_tools/__init__.py',
'src/build_tools/sdk_tools/sdk_update.py',
'src/build_tools/sdk_tools/sdk_update_main.py',
'src/build_tools/sdk_tools/sdk_update_common.py',
'src/build_tools/sdk_tools/download.py',
'src/build_tools/sdk_tools/command/info.py',
'src/build_tools/sdk_tools/command/sources.py',
'src/build_tools/sdk_tools/command/__init__.py',
'src/build_tools/sdk_tools/command/update.py',
'src/build_tools/sdk_tools/command/list.py',
'src/examples/debugging/handler.py', 'src/tools/decode_dump.py',
'src/tools/getos.py', 'src/tools/oshelpers.py', 'src/tools/compiler-wrapper.py',
'src/tools/genhttpfs.py', 'src/tools/quote.py', 'src/tools/quote_test.py',
'src/tools/run.py', 'src/tools/httpd.py', 'src/tools/create_nmf.py',
'src/tools/tests/httpd_test.py', 'src/tools/tests/chrome_mock.py',
'src/tools/tests/oshelpers_test.py', 'src/tools/tests/create_nmf_test.py']
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/PRESUBMIT_test.py
Running /b/commit-queue/workdir/chromium/native_client_sdk/PRESUBMIT.py
Running pylint on 51 files.

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    PRESUBMIT.py

Presubmit checks took 7.2s to calculate.

[Sam Clegg, 2013-02-11 23:14:50]

+maruel as PRESUBMIT.py OWNER.

[Sam Clegg, 2013-02-11 23:18:10]

https://chromiumcodereview.appspot.com/12209097/diff/10003/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/12209097/diff/10003/PRESUBMIT.py#newco...
PRESUBMIT.py:21: r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",
Actually, could we just make this *.mk, since Makefile
is already in the list below?

[M-A Ruel, 2013-02-11 23:23:38]

https://chromiumcodereview.appspot.com/12209097/diff/10003/PRESUBMIT.py
File PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/12209097/diff/10003/PRESUBMIT.py#newco...
PRESUBMIT.py:21: r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",
On 2013/02/11 23:18:10, Sam Clegg wrote:
> Actually, could we just make this *.mk, since Makefile
> is already in the list below?

I don't mind either way.

lgtm

[commit-bot: I haz the power, 2013-02-12 00:14:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/12209097/10003

[commit-bot: I haz the power, 2013-02-12 04:56:30]

Change committed as 181856