Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12209080: Cleanup: Remove deprecated base::Value methods from net. Use base::Value too. (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Cleanup: Remove deprecated base::Value methods from net. Use base::Value too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -112 lines) Patch
M net/base/address_list.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate_net_log_param.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/dns/dns_config_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/proxy/proxy_config.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_service.cc View 4 chunks +16 lines, -14 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/spdy/spdy_session.cc View 7 chunks +61 lines, -62 lines 0 comments Download
M net/test/base_test_server.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
7 years, 10 months ago (2013-02-09 03:01:46 UTC) #1
mmenke
Chris is off this month. I'll take this.
7 years, 10 months ago (2013-02-09 03:42:49 UTC) #2
mmenke
LGTM, and thinks for doing the other random cleanups as well!
7 years, 10 months ago (2013-02-11 16:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12209080/1
7 years, 10 months ago (2013-02-11 17:46:59 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-11 18:13:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12209080/1
7 years, 10 months ago (2013-02-11 21:42:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98345
7 years, 10 months ago (2013-02-12 01:15:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12209080/1
7 years, 10 months ago (2013-02-12 17:17:34 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 19:39:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 181979

Powered by Google App Engine
This is Rietveld 408576698