Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 12209076: [Sync] Enable searching sync setup overlay from settings (Closed)

Created:
7 years, 10 months ago by Nicolas Zea
Modified:
7 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[Sync] Enable searching sync setup overlay from settings Add customize-sync as the associatedControl of the sync setup overlay, enabling the search page to check its contents. BUG=174043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/options.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
PTAL. Note that this will currently still show the sync setup section for e.g. "encryption" ...
7 years, 10 months ago (2013-02-08 23:17:09 UTC) #1
csilv
lgtm
7 years, 10 months ago (2013-02-12 19:15:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/12209076/1
7 years, 10 months ago (2013-02-12 19:25:07 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 21:32:00 UTC) #4
Message was sent while issue was closed.
Change committed as 182019

Powered by Google App Engine
This is Rietveld 408576698