Issue 12209041: Add RECORD_AUDIO in Android manifest.

Issue 12209041: Add RECORD_AUDIO in Android manifest. (Closed)

Created:
7 years, 10 months ago by leozwang1

Modified:
7 years, 10 months ago

Reviewers:
wjia(left Chromium), Yaron

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, jochen+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Add RECORD_AUDIO in Android manifest. This CL enables audio capture on Android. BUG=161417 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181610

Patch Set 1 #

Patch Set 2 : correct typo #

Total comments: 2

Patch Set 3 : Address Yaron's comment #

Patch Set 4 : Per wjia@, add CAMERA #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
M	chrome/android/testshell/java/AndroidManifest.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/android/browsertests_apk/AndroidManifest.xml	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/shell/android/shell_apk/AndroidManifest.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/android/AndroidManifest.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

lgtm with nit: in description, it should be "manifest". Adding yfriedman@ for owner's stamp.

7 years, 10 months ago (2013-02-06 17:58:32 UTC) #1

Yaron

lgtm https://codereview.chromium.org/12209041/diff/5001/content/shell/android/shell_apk/AndroidManifest.xml File content/shell/android/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/12209041/diff/5001/content/shell/android/shell_apk/AndroidManifest.xml#newcode71 content/shell/android/shell_apk/AndroidManifest.xml:71: <uses-permission android:name="android.permission.RECORD_AUDIO"/> If there are content_browsertests that use ...

7 years, 10 months ago (2013-02-06 19:11:51 UTC) #2

leozwang1

/content/shell/android/browsertests_apk/AndroidManifest.xml is added. Will commit it if it passes trybots. https://codereview.chromium.org/12209041/diff/5001/content/shell/android/shell_apk/AndroidManifest.xml File content/shell/android/shell_apk/AndroidManifest.xml (right): https://codereview.chromium.org/12209041/diff/5001/content/shell/android/shell_apk/AndroidManifest.xml#newcode71 ...

7 years, 10 months ago (2013-02-06 23:10:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leozwang@chromium.org/12209041/11001

7 years, 10 months ago (2013-02-09 04:24:03 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=82832

7 years, 10 months ago (2013-02-09 07:05:57 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leozwang@chromium.org/12209041/11001

7 years, 10 months ago (2013-02-09 07:29:46 UTC) #6

Message was sent while issue was closed.

Change committed as 181610

Expand Messages | Collapse Messages