Prevent --ensure-google-update-present switch from blocking install if Google Update is missing.

Prevent --ensure-google-update-present switch from blocking install if Google Update is missing.

BUG=159200
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182268

[huangs, 2013-02-12 20:19:02]

Verified the problem and here's the simple fix.

[erikwright (departed), 2013-02-12 20:21:34]

On 2013/02/12 20:19:02, huangs1 wrote:
> Verified the problem and here's the simple fix.

What do you think about only allowing a failure if there was no Google Update at
system-level in the first place?

I have been thinking about this today because I resolved a bug in the activation
of user-level Google Update. If your fix had already been in, we would never
have even noticed the bug.

Sorry for the back and forth.

[huangs, 2013-02-12 20:43:28]

I was thinking about passing a bool flag to the
EnsureUserLevelGoogleUpdatePresent() to enable this behaviour.

[erikwright (departed), 2013-02-12 20:46:15]

On 2013/02/12 20:43:28, huangs1 wrote:
> I was thinking about passing a bool flag to the
> EnsureUserLevelGoogleUpdatePresent() to enable this behaviour.

I think it would be enough to make EnsureUserLevelGoogleUpdatePresent succeed in
all cases if there is no system-level Google Update, and to fail if there is a
system-level and we can't activate it at user-level.

[huangs, 2013-02-12 21:00:49]

PTAL.

[erikwright (departed), 2013-02-12 21:21:58]

LGTM. You'll need Greg or Gab to approve too.

[huangs, 2013-02-12 21:27:26]

Adding grt@ for quick OWNER review.

[grt (UTC plus 2), 2013-02-13 14:22:49]

lgtm w/ two nits

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
File chrome/installer/util/google_update_util.cc (right):

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
chrome/installer/util/google_update_util.cc:187: return true;
success = true; for consistency since this function doesn't do early-returns at
the other possible places.

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
File chrome/installer/util/google_update_util.h (right):

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
chrome/installer/util/google_update_util.h:15: // if Google Update is not
installed.
"is not installed" -> "is not present at system-level" if that's what's really
meant.

[huangs, 2013-02-13 15:35:28]

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
File chrome/installer/util/google_update_util.cc (right):

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
chrome/installer/util/google_update_util.cc:187: return true;
On 2013/02/13 14:22:49, grt wrote:
> success = true; for consistency since this function doesn't do early-returns
at
> the other possible places.

Done.

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
File chrome/installer/util/google_update_util.h (right):

https://codereview.chromium.org/12208135/diff/5001/chrome/installer/util/goog...
chrome/installer/util/google_update_util.h:15: // if Google Update is not
installed.
On 2013/02/13 14:22:49, grt wrote:
> "is not installed" -> "is not present at system-level" if that's what's really
> meant.

Done.

[commit-bot: I haz the power, 2013-02-13 15:37:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/12208135/12002

[commit-bot: I haz the power, 2013-02-13 18:44:30]

Change committed as 182268