Issue 12208128: Telemetry fix: .wpr metadata layer with missing metadata again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12208128: Telemetry fix: .wpr metadata layer with missing metadata again. (Closed)

Created:
7 years, 10 months ago by marja

Modified:
7 years, 10 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry fix: .wpr metadata layer with missing metadata again. (Fixing https://codereview.chromium.org/11881051/ .) TBR=tonyg BUG=155660 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181909

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/telemetry/telemetry/browser_credentials.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/12208128/1

7 years, 10 months ago (2013-02-12 10:06:52 UTC) #1

nduca

Is there unittest coverage we should have to help with this case?

7 years, 10 months ago (2013-02-12 19:06:39 UTC) #4

marja

On 2013/02/12 19:06:39, nduca wrote: > Is there unittest coverage we should have to help ...

7 years, 10 months ago (2013-02-12 20:17:17 UTC) #5

nduca

7 years, 10 months ago (2013-02-12 20:19:38 UTC) #6

Message was sent while issue was closed.

Hehe, if that was the issue, then I think we're okay. Thanks for clarifying!

[back story: I think we'll move to test data to cloud storage, pending some
investigation by rachel. That will clean up this mess for good]

Expand Messages | Collapse Messages