Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 12208091: ExtensionInfobarGtk doesn't handle delegate going away. (Closed)

Created:
7 years, 10 months ago by Joe Thomas
Modified:
7 years, 10 months ago
Reviewers:
Finnur, Evan Stade
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ExtensionInfobarGtk doesn't handle delegate going away. The delegate can go away while we asynchronously load images. To handle this case, ExtensionInfobarGtk should register itself as DelegateObserver with the ExtensionInfoBarDelegate and handle the Delegate Deletion case. BUG=162662 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Joe Thomas
finnur@ Could you please review this CL? Thanks
7 years, 10 months ago (2013-02-08 20:49:43 UTC) #1
Finnur
LGTM
7 years, 10 months ago (2013-02-10 21:38:50 UTC) #2
Joe Thomas
On 2013/02/10 21:38:50, Finnur wrote: > LGTM Thanks for the review!
7 years, 10 months ago (2013-02-11 02:13:47 UTC) #3
Joe Thomas
+Evan Stade for OWNERS
7 years, 10 months ago (2013-02-11 02:15:43 UTC) #4
Finnur
Is this the same bug as: http://crbug.com/162658
7 years, 10 months ago (2013-02-11 10:07:34 UTC) #5
Joe Thomas
On 2013/02/11 10:07:34, Finnur wrote: > Is this the same bug as: > http://crbug.com/162658 It ...
7 years, 10 months ago (2013-02-11 19:50:45 UTC) #6
Evan Stade
lgtm
7 years, 10 months ago (2013-02-11 20:01:47 UTC) #7
Joe Thomas
On 2013/02/11 20:01:47, Evan Stade wrote: > lgtm Thanks for the review.
7 years, 10 months ago (2013-02-11 20:03:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12208091/1
7 years, 10 months ago (2013-02-11 20:04:49 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=83178
7 years, 10 months ago (2013-02-11 23:44:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12208091/1
7 years, 10 months ago (2013-02-12 00:13:35 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 01:55:10 UTC) #12
Message was sent while issue was closed.
Change committed as 181818

Powered by Google App Engine
This is Rietveld 408576698