chrome/browser/system_monitor/removable_storage_notifications.h - Issue 12208079: Move TransientDeviceId from MediFileSystemRegistry to RemovableStorageNotifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/system_monitor/removable_storage_notifications.h

Issue 12208079: Move TransientDeviceId from MediFileSystemRegistry to RemovableStorageNotifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Abstract a bit better Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc ('K') | « chrome/browser/media_gallery/transient_device_ids.cc ('k') | chrome/browser/system_monitor/removable_storage_notifications.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/system_monitor/removable_storage_notifications.h

diff --git a/chrome/browser/system_monitor/removable_storage_notifications.h b/chrome/browser/system_monitor/removable_storage_notifications.h

index e916dea83fdc0ed3f1fadb65729e269f983a5234..f89d9a322642f13789befbeff97e36cd1a10137e 100644

--- a/chrome/browser/system_monitor/removable_storage_notifications.h

+++ b/chrome/browser/system_monitor/removable_storage_notifications.h

@@ -18,6 +18,7 @@ namespace chrome {

class MediaFileSystemRegistryTest;

class RemovableStorageObserver;

+class TransientDeviceIds;

// Base class for platform-specific instances watching for removable storage

// attachments/detachments.

@@ -83,6 +84,8 @@ class RemovableStorageNotifications {

void AddObserver(RemovableStorageObserver* obs);

void RemoveObserver(RemovableStorageObserver* obs);

+ uint64 GetTransientIdForDeviceId(const std::string& device_id);

protected:

RemovableStorageNotifications();

virtual ~RemovableStorageNotifications();

@@ -114,6 +117,8 @@ class RemovableStorageNotifications {

// Map of all the attached removable storage devices.

RemovableStorageMap storage_map_;

+ scoped_ptr<TransientDeviceIds> transient_device_ids_;

Lei Zhang 2013/02/12 16:48:01 Does this need to be a scoped_ptr?

vandebo (ex-Chrome) 2013/02/12 21:40:57 No, it's just a scoped_ptr to reduce the number of

};

} // namespace chrome