Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12208078: Move chrome/common/extensions/event_* to extensions/common/ (Closed)

Created:
7 years, 10 months ago by Joe Thomas
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move EventFilter, EventFilteringInfo and EventMatcher classes to extensions/common/ TBR=ben@chromium.org BUG=162530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181849

Patch Set 1 #

Total comments: 1

Patch Set 2 : v8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -769 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_listener_map.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/event_filter.h View 1 chunk +0 lines, -126 lines 0 comments Download
D chrome/common/extensions/event_filter.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D chrome/common/extensions/event_filter_unittest.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/common/extensions/event_filtering_info.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/common/extensions/event_filtering_info.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/common/extensions/event_matcher.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/common/extensions/event_matcher.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 2 chunks +1 line, -1 line 0 comments Download
A + extensions/common/event_filter.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/common/event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/event_filter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + extensions/common/event_filtering_info.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + extensions/common/event_filtering_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/common/event_matcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/event_matcher.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Joe Thomas
7 years, 10 months ago (2013-02-08 01:33:10 UTC) #1
Yoyo Zhou
Please write out chrome/common/... fully in the changelist description. The reasoning is that commit logs ...
7 years, 10 months ago (2013-02-11 19:50:59 UTC) #2
Joe Thomas
On 2013/02/11 19:50:59, Yoyo Zhou wrote: > Please write out chrome/common/... fully in the changelist ...
7 years, 10 months ago (2013-02-11 22:08:11 UTC) #3
Yoyo Zhou
LGTM
7 years, 10 months ago (2013-02-11 22:15:38 UTC) #4
Joe Thomas
On 2013/02/11 22:15:38, Yoyo Zhou wrote: > LGTM Thanks for the review.
7 years, 10 months ago (2013-02-11 22:16:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12208078/3001
7 years, 10 months ago (2013-02-11 22:19:41 UTC) #6
commit-bot: I haz the power
Presubmit check for 12208078-3001 failed and returned exit status 1. INFO:root:Found 15 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-11 22:20:06 UTC) #7
Joe Thomas
TBR=ben
7 years, 10 months ago (2013-02-11 22:21:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12208078/3001
7 years, 10 months ago (2013-02-11 22:24:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/12208078/3001
7 years, 10 months ago (2013-02-12 03:42:50 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 04:46:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 181849

Powered by Google App Engine
This is Rietveld 408576698