Add a set passphrase dialog for managed user accounts.

Add a set passphrase dialog which allows to set a passphrase for a managed user account. In a later changelist this will be used for authentication in order to change settings of the account.
This changelist is extracted from the changelist here: https://codereview.chromium.org/11783008/ in order to break it up.
A screenshot of the set passphrase page is available here:
https://docs.google.com/a/google.com/drawings/d/1qXtLoSN2C8Z_qrnNB8yHlJHG96NqL79ciMGaW3amWkw/edit?usp=sharing

BUG=171370
TEST=browser_tests, unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181812

[Adrian Kuegel, 2013-02-07 14:49:32]

Bernhard, can you please take a quick look at this changelist? It is basically
an extract of the other changelist you already reviewed, with minor fixes (years
in new files changed to 2013, and added margins for the set passphrase dialog).

[Bernhard Bauer, 2013-02-07 15:33:10]

LGTM with some nits I've previously overlooked (that's what you get for asking
me again!):

https://codereview.chromium.org/12208068/diff/2001/chrome/browser/managed_mod...
File chrome/browser/managed_mode/managed_user_passphrase.cc (right):

https://codereview.chromium.org/12208068/diff/2001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_passphrase.cc:52: // Create a hash from
the user-provided passphrase and our hard-coded salt.
Nit: the "hardcoded" part in the comment doesn't apply anymore.

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h...
chrome/common/pref_names.h:24: extern const char kManagedModeLocalPassphrase[];
Nit: Alphabetize please.

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h...
chrome/common/pref_names.h:31: extern const char kDisableScreenshots[];
Nit: while you're at it, could you alphabetize this as well?

[Adrian Kuegel, 2013-02-07 16:31:26]

https://codereview.chromium.org/12208068/diff/2001/chrome/browser/managed_mod...
File chrome/browser/managed_mode/managed_user_passphrase.cc (right):

https://codereview.chromium.org/12208068/diff/2001/chrome/browser/managed_mod...
chrome/browser/managed_mode/managed_user_passphrase.cc:52: // Create a hash from
the user-provided passphrase and our hard-coded salt.
On 2013/02/07 15:33:11, Bernhard Bauer wrote:
> Nit: the "hardcoded" part in the comment doesn't apply anymore.

Done.

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h...
chrome/common/pref_names.h:24: extern const char kManagedModeLocalPassphrase[];
This happened during the rebase, I guess it was correct before, so no wonder you
missed it :-)

https://codereview.chromium.org/12208068/diff/2001/chrome/common/pref_names.h...
chrome/common/pref_names.h:31: extern const char kDisableScreenshots[];
On 2013/02/07 15:33:11, Bernhard Bauer wrote:
> Nit: while you're at it, could you alphabetize this as well?

Done.

[Adrian Kuegel, 2013-02-07 16:35:22]

@James: Could you please give me owners approval for all files except the ones
in chrome/browser/managed_mode?
I added some margins in the set passphrase dialog, but I am also waiting for
feedback from the UI team and I will continue working on this, but preferably in
another changelist.

[James Hawkins, 2013-02-07 17:48:09]

On 2013/02/07 16:35:22, Adrian Kuegel wrote:
> @James: Could you please give me owners approval for all files except the ones
> in chrome/browser/managed_mode?
> I added some margins in the set passphrase dialog, but I am also waiting for
> feedback from the UI team and I will continue working on this, but preferably
in
> another changelist.

Note that the .png resource is going to have to be added in a separate CL in
order to get successful try jobs for this CL.

[Adrian Kuegel, 2013-02-11 09:54:46]

James, can you please take another look? I have extracted the
managed_user_passphrase files and they have been committed separately. The
change in managed_user_service.cc is needed in this changelist, as it registers
the preferences which will hold the passphrase and the salt.

[James Hawkins, 2013-02-11 18:04:19]

LGTM with nits. Thanks!

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/resources/...
File chrome/browser/resources/options/managed_user_set_passphrase.html (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/resources/...
chrome/browser/resources/options/managed_user_set_passphrase.html:9: </div>
nit: I think this can fit on the line above.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc:33:
web_ui()->RegisterMessageCallback("setPassphrase",
nit: Start of parameter rows must align on the same column.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_passphrase_handler.h (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.h:31: void
SetLocalPassphrase(const base::ListValue* args);
nit: Document method.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.h:33:
std::string callback_function_name_;
nit: Document member variable.

[Adrian Kuegel, 2013-02-11 18:34:46]

Thanks for the review.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/resources/...
File chrome/browser/resources/options/managed_user_set_passphrase.html (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/resources/...
chrome/browser/resources/options/managed_user_set_passphrase.html:9: </div>
On 2013/02/11 18:04:19, James Hawkins wrote:
> nit: I think this can fit on the line above.

Done.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc:33:
web_ui()->RegisterMessageCallback("setPassphrase",
On 2013/02/11 18:04:19, James Hawkins wrote:
> nit: Start of parameter rows must align on the same column.

Done.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/managed_user_passphrase_handler.h (right):

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.h:31: void
SetLocalPassphrase(const base::ListValue* args);
On 2013/02/11 18:04:19, James Hawkins wrote:
> nit: Document method.

Done.

https://codereview.chromium.org/12208068/diff/10025/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/managed_user_passphrase_handler.h:33:
std::string callback_function_name_;
This variable is actually unused in this changelist, I forgot to remove it when
extracting from the other changelist. But I will document it in the other
changelist.

[commit-bot: I haz the power, 2013-02-11 18:36:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/12208068/11006

[commit-bot: I haz the power, 2013-02-11 19:10:13]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-11 21:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/12208068/10033

[commit-bot: I haz the power, 2013-02-12 01:40:03]

Change committed as 181812