Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 12208040: [win] Add a progress bar in the app launcher for app installs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix linux compile Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index f76efd3690e4301c11b396f66eae7f09d72d917d..e218bbe83006d8d0196e348623cb0370c2c3107a 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -468,9 +468,11 @@ void CompleteInstallFunction::OnGetAppLauncherEnabled(
bool app_launcher_enabled) {
if (app_launcher_enabled) {
std::string name;
- DCHECK(approval_->parsed_manifest->GetString(extension_manifest_keys::kName,
- &name));
#if defined(ENABLE_APP_LIST)
+ if (!approval_->parsed_manifest->GetString(extension_manifest_keys::kName,
+ &name)) {
+ NOTREACHED();
+ }
// Tell the app list about the install that we just started.
chrome::NotifyAppListOfBeginExtensionInstall(
profile(), id, name, approval_->installing_icon);
@@ -513,6 +515,14 @@ void CompleteInstallFunction::OnExtensionInstallFailure(
Release();
}
+void CompleteInstallFunction::OnExtensionDownloadProgress(
+ const std::string& id,
+ content::DownloadItem* item) {
+#if defined(ENABLE_APP_LIST)
+ chrome::NotifyAppListOfDownloadProgress(profile(), id,
+ item->PercentComplete());
+#endif
+}
bool GetBrowserLoginFunction::RunImpl() {
SetResult(CreateLoginResult(profile_->GetOriginalProfile()));
« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.h ('k') | chrome/browser/ui/app_list/app_list_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698