Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 12208028: Exclude duplicate gmock_mutant functor templates in WIN64 (Closed)

Created:
7 years, 10 months ago by wolenetz
Modified:
7 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude duplicate gmock_mutant functor templates in WIN64 On WIN64, there is only one calling convention. Therefore, implicit calling conventions and __stdcall are the same, hence template redefinition errors occur in the previous gmock_mutant.h on WIN64. BUG=173697, 166496 TEST=media_unittests target builds without template redefinition errors. With other build errors fixed in privates (ignore C4267 & lift MEDIA...INTRINSICS... definition into yuv_convert.h and use it to not link in methods that use MMX intrinsics), media_unittests executes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181348

Patch Set 1 #

Total comments: 8

Patch Set 2 : Revert script copyright and use && in WIN64 condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -102 lines) Patch
M testing/generate_gmock_mutant.py View 1 3 chunks +5 lines, -3 lines 0 comments Download
M testing/gmock_mutant.h View 1 99 chunks +99 lines, -99 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wolenetz
Stoyan@: please review all DaleCurtis@: please review relative to media_unittests usage & python readability Thanks, ...
7 years, 10 months ago (2013-02-05 21:03:00 UTC) #1
DaleCurtis
https://codereview.chromium.org/12208028/diff/1/testing/generate_gmock_mutant.py File testing/generate_gmock_mutant.py (right): https://codereview.chromium.org/12208028/diff/1/testing/generate_gmock_mutant.py#newcode2 testing/generate_gmock_mutant.py:2: # Copyright (c) 2013 The Chromium Authors. All rights ...
7 years, 10 months ago (2013-02-05 21:07:38 UTC) #2
wolenetz
Please review PS2. The items in "TEST=" have been confirmed. Thanks, Matt https://codereview.chromium.org/12208028/diff/1/testing/generate_gmock_mutant.py File testing/generate_gmock_mutant.py ...
7 years, 10 months ago (2013-02-05 21:38:46 UTC) #3
DaleCurtis
lgtm
7 years, 10 months ago (2013-02-05 21:40:24 UTC) #4
wolenetz
On 2013/02/05 21:40:24, DaleCurtis wrote: > lgtm I received LGTM in email from stoyan@. I ...
7 years, 10 months ago (2013-02-06 18:44:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12208028/6001
7 years, 10 months ago (2013-02-06 18:45:19 UTC) #6
wolenetz
On 2013/02/06 18:45:19, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 10 months ago (2013-02-07 00:05:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12208028/6001
7 years, 10 months ago (2013-02-07 02:03:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12208028/6001
7 years, 10 months ago (2013-02-07 17:06:00 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 19:20:22 UTC) #10
Message was sent while issue was closed.
Change committed as 181348

Powered by Google App Engine
This is Rietveld 408576698