src/hydrogen.h - Issue 12208013: Separated smi check from HBoundsCheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.h

Issue 12208013: Separated smi check from HBoundsCheck. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed review comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.h

diff --git a/src/hydrogen.h b/src/hydrogen.h

index e9b8a2fa836c01e2316a3c884614c497657b7709..7c34bbaf3c184953fa829b80c5c2042db393e62a 100644

--- a/src/hydrogen.h

+++ b/src/hydrogen.h

@@ -875,6 +875,11 @@ class HGraphBuilder {

HInstruction* AddInstruction(HInstruction* instr);

void AddSimulate(BailoutId id,

RemovableSimulate removable = FIXED_SIMULATE);

+ HBoundsCheck* AddBoundsCheck(

Jakob Kummerow 2013/02/07 16:17:14 Since this is not used for stubs, please move it t

Massi 2013/02/11 10:35:55 I tried, but it is used in HGraphBuilder::BuildUnc

+ HValue* index,

+ HValue* length,

+ BoundsCheckKeyMode key_mode = DONT_ALLOW_SMI_KEY,

+ Representation r = Representation::None());

protected:

virtual bool BuildGraph() = 0;