Separated smi check from HBoundsCheck.

src/ia32/lithium-ia32.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 68 matching lines @@
   V(CmpMapAndBranch)                            \
   V(CmpT)                                       \
   V(CmpConstantEqAndBranch)                     \
   V(ConstantD)                                  \
   V(ConstantI)                                  \
   V(ConstantT)                                  \
   V(Context)                                    \
   V(DeclareGlobals)                             \
   V(DeleteProperty)                             \
   V(Deoptimize)                                 \
+  V(DeoptimizeIfTaggedIsNotSmi)                 \
   V(DivI)                                       \
   V(DoubleToI)                                  \
   V(DummyUse)                                   \
   V(ElementsKind)                               \
   V(FastLiteral)                                \
   V(FixedArrayBaseLength)                       \
   V(FunctionLiteral)                            \
   V(GetCachedArrayIndex)                        \
   V(GlobalObject)                               \
   V(GlobalReceiver)                             \
@@ skipping 2169 matching lines @@
   explicit LCheckSmi(LOperand* value) {
     inputs_[0] = value;
   }
 
   LOperand* value() { return inputs_[0]; }
 
   DECLARE_CONCRETE_INSTRUCTION(CheckSmi, "check-smi")
 };
 
 
+class LDeoptimizeIfTaggedIsNotSmi: public LTemplateInstruction<0, 1, 0> {

[Jakob Kummerow, 2013/02/06 13:43:59]

I think we don't need a new LInstruction.
Instead, I think the "representation.IsTagged() && !type.IsSmi()" logic should
go into the Canonicalization phase, i.e. the HDeoptimizeIfTaggedIsNotSmi should
just remove itself when it is not needed. When it is needed, we can simply
translate it to an LCheckSmi. Or am I missing something?

[Massi, 2013/02/06 19:12:31]

Done.

+ public:
+  explicit LDeoptimizeIfTaggedIsNotSmi(LOperand* value) {
+    inputs_[0] = value;
+  }
+
+  LOperand* value() { return inputs_[0]; }
+
+  DECLARE_CONCRETE_INSTRUCTION(DeoptimizeIfTaggedIsNotSmi,
+                               "deoptimize-if-tagged-is-not-smi")
+};
+
+
 class LClampDToUint8: public LTemplateInstruction<1, 1, 0> {
  public:
   explicit LClampDToUint8(LOperand* value) {
     inputs_[0] = value;
   }
 
   LOperand* unclamped() { return inputs_[0]; }
 
   DECLARE_CONCRETE_INSTRUCTION(ClampDToUint8, "clamp-d-to-uint8")
 };
@@ skipping 487 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
 };
 
 #undef DECLARE_HYDROGEN_ACCESSOR
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_IA32_LITHIUM_IA32_H_