Issue 12207199: Removed invalid NOTREACHED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207199: Removed invalid NOTREACHED. (Closed)

Created:
7 years, 10 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 10 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed invalid NOTREACHED. It's possible when new Chrome opened on profile created with older one that had no support of this option. TBR=gene Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182769

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -15 lines)			Patch
	M	printing/printing_context.cc	View		3 chunks	+7 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12207199/1

7 years, 10 months ago (2013-02-15 05:12:21 UTC) #2

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=11256

7 years, 10 months ago (2013-02-15 17:20:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12207199/1

7 years, 10 months ago (2013-02-15 18:18:28 UTC) #5

Message was sent while issue was closed.

Change committed as 182769

Expand Messages | Collapse Messages