Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: build/android/pylib/base/base_test_sharder.py

Issue 12207172: Change Android retry logic - always retry 3 times. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/base_test_sharder.py
diff --git a/build/android/pylib/base/base_test_sharder.py b/build/android/pylib/base/base_test_sharder.py
index 5ff9b6209afa360d8898450feae9ec7b93d74cad..ebb4cbdf70480dc09e904e52cf067660272c8929 100644
--- a/build/android/pylib/base/base_test_sharder.py
+++ b/build/android/pylib/base/base_test_sharder.py
@@ -54,7 +54,7 @@ class BaseTestSharder(object):
# We should differentiate between these. Otherwise, blindly retrying tests
# might mask test/product flakiness. For type 2, we should follow the
# general chrome best practices.
- self.retries = len(self.attached_devices)
+ self.retries = 3
frankf 2013/02/14 03:42:15 Do you have some data why the tot bot was flaky? R
Isaac (away) 2013/02/14 06:38:50 I agree this code would be better if we distinguis
frankf 2013/02/14 06:43:48 Let's define it as a constant at the top of the mo
Isaac (away) 2013/02/14 06:53:10 Done.
Yaron 2013/02/14 16:59:27 It wasn't the bot that was flaky (it only had one
self.tests = []
self.build_type = build_type
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698