Issue 12207171: [Android] Add a dummy host-driven test for ChromiumTestShell.

Issue 12207171: [Android] Add a dummy host-driven test for ChromiumTestShell. (Closed)

Created:
7 years, 10 months ago by frankf

Modified:
7 years, 10 months ago

Reviewers:
craigdh, bulach

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Add a dummy host-driven test for ChromiumTestShell. Currently, we have no host-driven tests upstream. This dummy test verifies the functionality of the framework. NOTRY=True BUG=168255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182512

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -10 lines)			Patch
M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	build/android/pylib/constants.py	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	build/android/pylib/host_driven/run_python_tests.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A	chrome/android/host_driven_tests/DummyTest.py	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyTest.java	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

frankf

@bulach: Let me know if there's a more appropriate place for these tests.

7 years, 10 months ago (2013-02-14 02:48:12 UTC) #1

bulach

lgtm so we're actually going ahead with these host-driven tests? :) looking forward to see ...

7 years, 10 months ago (2013-02-14 13:51:42 UTC) #2

craigdh

lgtm. https://codereview.chromium.org/12207171/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/12207171/diff/1/build/android/pylib/constants.py#newcode11 build/android/pylib/constants.py:11: '..', '..', '..')) '..' -> os.pardir

7 years, 10 months ago (2013-02-14 17:19:20 UTC) #3

frankf

@bulach: crbug.com/176323 is tracking host-driven framework changes. https://codereview.chromium.org/12207171/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/12207171/diff/1/build/android/pylib/constants.py#newcode11 build/android/pylib/constants.py:11: '..', '..', ...

7 years, 10 months ago (2013-02-14 19:24:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/12207171/2003

7 years, 10 months ago (2013-02-14 19:26:35 UTC) #5

Message was sent while issue was closed.

Change committed as 182512

Expand Messages | Collapse Messages