Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5043)

Unified Diff: chrome/common/custom_handlers/protocol_handler.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/extension_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/custom_handlers/protocol_handler.cc
===================================================================
--- chrome/common/custom_handlers/protocol_handler.cc (revision 182296)
+++ chrome/common/custom_handlers/protocol_handler.cc (working copy)
@@ -28,7 +28,7 @@
ProtocolHandler::ProtocolHandler() {
}
-bool ProtocolHandler::IsValidDict(const DictionaryValue* value) {
+bool ProtocolHandler::IsValidDict(const base::DictionaryValue* value) {
return value->HasKey("protocol") && value->HasKey("url") &&
value->HasKey("title");
}
@@ -44,7 +44,7 @@
}
ProtocolHandler ProtocolHandler::CreateProtocolHandler(
- const DictionaryValue* value) {
+ const base::DictionaryValue* value) {
if (!IsValidDict(value)) {
return EmptyProtocolHandler();
}
@@ -63,11 +63,11 @@
return GURL(translatedUrlSpec);
}
-DictionaryValue* ProtocolHandler::Encode() const {
- DictionaryValue* d = new DictionaryValue();
- d->Set("protocol", Value::CreateStringValue(protocol_));
- d->Set("url", Value::CreateStringValue(url_.spec()));
- d->Set("title", Value::CreateStringValue(title_));
+base::DictionaryValue* ProtocolHandler::Encode() const {
+ base::DictionaryValue* d = new base::DictionaryValue();
+ d->Set("protocol", new base::StringValue(protocol_));
+ d->Set("url", new base::StringValue(url_.spec()));
+ d->Set("title", new base::StringValue(title_));
return d;
}
« no previous file with comments | « no previous file | chrome/common/extensions/api/extension_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698