Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3763)

Unified Diff: chrome/common/extensions/value_builder.cc

Issue 12207167: Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/value_builder.cc
===================================================================
--- chrome/common/extensions/value_builder.cc (revision 182296)
+++ chrome/common/extensions/value_builder.cc (working copy)
@@ -20,25 +20,25 @@
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
int in_value) {
- dict_->SetWithoutPathExpansion(path, Value::CreateIntegerValue(in_value));
+ dict_->SetWithoutPathExpansion(path, new base::FundamentalValue(in_value));
return *this;
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
double in_value) {
- dict_->SetWithoutPathExpansion(path, Value::CreateDoubleValue(in_value));
+ dict_->SetWithoutPathExpansion(path, new base::FundamentalValue(in_value));
return *this;
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
const std::string& in_value) {
- dict_->SetWithoutPathExpansion(path, Value::CreateStringValue(in_value));
+ dict_->SetWithoutPathExpansion(path, new base::StringValue(in_value));
return *this;
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
const string16& in_value) {
- dict_->SetWithoutPathExpansion(path, Value::CreateStringValue(in_value));
+ dict_->SetWithoutPathExpansion(path, new base::StringValue(in_value));
return *this;
}
@@ -56,7 +56,7 @@
DictionaryBuilder& DictionaryBuilder::SetBoolean(
const std::string& path, bool in_value) {
- dict_->SetWithoutPathExpansion(path, Value::CreateBooleanValue(in_value));
+ dict_->SetWithoutPathExpansion(path, new base::FundamentalValue(in_value));
return *this;
}
@@ -67,22 +67,22 @@
ListBuilder::~ListBuilder() {}
ListBuilder& ListBuilder::Append(int in_value) {
- list_->Append(Value::CreateIntegerValue(in_value));
+ list_->Append(new base::FundamentalValue(in_value));
return *this;
}
ListBuilder& ListBuilder::Append(double in_value) {
- list_->Append(Value::CreateDoubleValue(in_value));
+ list_->Append(new base::FundamentalValue(in_value));
return *this;
}
ListBuilder& ListBuilder::Append(const std::string& in_value) {
- list_->Append(Value::CreateStringValue(in_value));
+ list_->Append(new base::StringValue(in_value));
return *this;
}
ListBuilder& ListBuilder::Append(const string16& in_value) {
- list_->Append(Value::CreateStringValue(in_value));
+ list_->Append(new base::StringValue(in_value));
return *this;
}
@@ -97,7 +97,7 @@
}
ListBuilder& ListBuilder::AppendBoolean(bool in_value) {
- list_->Append(Value::CreateBooleanValue(in_value));
+ list_->Append(new base::FundamentalValue(in_value));
return *this;
}
« no previous file with comments | « chrome/common/extensions/permissions/socket_permission_data.cc ('k') | chrome/common/json_schema_validator_unittest_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698