Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12207143: Fix the badly inverted flag to show caps lock settings. (Closed)

Created:
7 years, 10 months ago by yoshiki
Modified:
7 years, 10 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix the badly inverted flag to show caps lock settings. BUG=174924 TEST=on lumpy, launch the settings page, and confirm the setting is hidden. R=nona@chromium.org TBR=nkostylev@chromium.org # TBR for just inverting the flag... Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yoshiki
7 years, 10 months ago (2013-02-13 02:48:10 UTC) #1
Seigo Nonaka
lgtm
7 years, 10 months ago (2013-02-13 02:48:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/12207143/1
7 years, 10 months ago (2013-02-13 02:55:30 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 08:21:05 UTC) #4
Message was sent while issue was closed.
Change committed as 182160

Powered by Google App Engine
This is Rietveld 408576698