Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12207138: Remove unused ntp_search. (Closed)

Created:
7 years, 10 months ago by MAD
Modified:
7 years, 10 months ago
Reviewers:
jhawkins, dhollowa
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Remove unused ntp_search. Since this is just removal of unused code, I TBR James for the OWNER's review... TBR=jhawkins@chromium.org BUG=175850 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -7010 lines) Patch
M chrome/browser/browser_resources.grd View 2 chunks +2 lines, -4 lines 0 comments Download
D chrome/browser/resources/ntp_search/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/ntp_search/apps_page.css View 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/resources/ntp_search/apps_page.js View 1 chunk +0 lines, -767 lines 0 comments Download
D chrome/browser/resources/ntp_search/dot_list.js View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/debug.css View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---amazon.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---cnn.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---ebay.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---news.ycombinator.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---nytimes.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---wefunkradio.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---www.deviantart.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---www.google.com-chrome-intl-en-welcome.html.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---www.wikipedia.org-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/http---youtube.com-.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/images/https---chrome.google.com-webstore-hl-en.jpg View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/mock.html View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/mock.js View 1 chunk +0 lines, -363 lines 0 comments Download
D chrome/browser/resources/ntp_search/mock/mock_data_autogen.js View 1 chunk +0 lines, -1618 lines 0 comments Download
D chrome/browser/resources/ntp_search/most_visited_page.css View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/resources/ntp_search/most_visited_page.js View 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/browser/resources/ntp_search/nav_dot.css View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/resources/ntp_search/nav_dot.js View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/resources/ntp_search/new_tab.css View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/resources/ntp_search/new_tab.html View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/resources/ntp_search/new_tab.js View 1 chunk +0 lines, -1181 lines 0 comments Download
D chrome/browser/resources/ntp_search/new_tab_theme.css View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/resources/ntp_search/position_util.js View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/resources/ntp_search/thumbnail_page.css View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/resources/ntp_search/thumbnail_page.js View 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/resources/ntp_search/tile_page.css View 1 chunk +0 lines, -257 lines 0 comments Download
D chrome/browser/resources/ntp_search/tile_page.js View 1 chunk +0 lines, -1132 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
MAD
I think this contains all the tentacles of the ntp_search... There are not that many, ...
7 years, 10 months ago (2013-02-12 23:53:50 UTC) #1
dhollowa
I think that's it. Thanks for the cleanup. LGTM.
7 years, 10 months ago (2013-02-13 00:28:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/12207138/1
7 years, 10 months ago (2013-02-13 01:56:49 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 11:42:18 UTC) #4
Message was sent while issue was closed. 
Change committed as 182191

Powered by Google App Engine
This is Rietveld 408576698