Issue 12207129: Disable RTC in coverage builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207129: Disable RTC in coverage builds. (Closed)

Created:
7 years, 10 months ago by chrisha

Modified:
7 years, 10 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disable RTC in coverage builds. Syzygy is unable to instrument some of the Chrome tests (browser_tests and unit_tests) due to interactions with RTC. Disable them so that we can collect full coverage stats. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182004

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

chrisha

PTAL. https://codereview.chromium.org/12207129/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12207129/diff/1/build/common.gypi#newcode1888 build/common.gypi:1888: 'win_debug_RuntimeChecks': '0', It's not immediately evident looking at ...

7 years, 10 months ago (2013-02-12 18:37:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/12207129/1

7 years, 10 months ago (2013-02-12 18:39:14 UTC) #4

Message was sent while issue was closed.

Change committed as 182004

Expand Messages | Collapse Messages