Ignore DEP and SEHOP flags on Win64

Ignore DEP and SEHOP flags on Win64

These flags aren't supported on 64-bit and can throw an error on Win8 process creation.

BUG=147752
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181840

[cpu_(ooo_6.6-7.5), 2013-02-11 19:05:09]

https://codereview.chromium.org/12207106/diff/1/content/common/sandbox_policy.cc
File content/common/sandbox_policy.cc (left):

https://codereview.chromium.org/12207106/diff/1/content/common/sandbox_policy...
content/common/sandbox_policy.cc:749: // TODO(jschuh): Make Win64 work with DEP
and SEHOP. crbug.com/147752
in the CL you have bug 158133

https://codereview.chromium.org/12207106/diff/1/sandbox/win/src/process_mitig...
File sandbox/win/src/process_mitigations.cc (right):

https://codereview.chromium.org/12207106/diff/1/sandbox/win/src/process_mitig...
sandbox/win/src/process_mitigations.cc:195: #if !defined(_WIN64)
I don't like the silent ignore. in sandbox_policy_base we return
SBOX_ERROR_BAD_PARAMS in PolicyBase::SetProcessMitigations so we should do that
here.

[jschuh, 2013-02-11 21:26:49]

https://codereview.chromium.org/12207106/diff/1/content/common/sandbox_policy.cc
File content/common/sandbox_policy.cc (left):

https://codereview.chromium.org/12207106/diff/1/content/common/sandbox_policy...
content/common/sandbox_policy.cc:749: // TODO(jschuh): Make Win64 work with DEP
and SEHOP. crbug.com/147752
On 2013/02/11 19:05:09, cpu wrote:
> in the CL you have bug 158133

Okay... you caught me. I don't know how to read.

https://codereview.chromium.org/12207106/diff/1/sandbox/win/src/process_mitig...
File sandbox/win/src/process_mitigations.cc (right):

https://codereview.chromium.org/12207106/diff/1/sandbox/win/src/process_mitig...
sandbox/win/src/process_mitigations.cc:195: #if !defined(_WIN64)
On 2013/02/11 19:05:09, cpu wrote:
> I don't like the silent ignore. in sandbox_policy_base we return
> SBOX_ERROR_BAD_PARAMS in PolicyBase::SetProcessMitigations so we should do
that
> here.

But it's ignored because the OS is already enforcing the behavior. And I didn't
want the mitigation interface to force the caller to enumerate through the
complicated tree of what OS versions support what mitigations. I designed it to
just encapsulate the logic and do the right thing, failing only when the OS
doesn't support something that it should.

[cpu_(ooo_6.6-7.5), 2013-02-11 22:44:41]

lgtm

[commit-bot: I haz the power, 2013-02-11 22:52:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/12207106/1

[commit-bot: I haz the power, 2013-02-12 03:46:43]

Change committed as 181840