Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 12207102: Fixed misnamed function call in popup.js in Chrome Extension tutorial (Closed)

Created:
7 years, 10 months ago by alancutter (OOO until 2018)
Modified:
7 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/docs/examples/tutorials/getstarted/popup.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
alancutter (OOO until 2018)
Hi this is my first Chromium commit, please let me know if I made any ...
7 years, 10 months ago (2013-02-11 02:26:09 UTC) #1
Mike West
On 2013/02/11 02:26:09, alancutter wrote: > Hi this is my first Chromium commit, please let ...
7 years, 10 months ago (2013-02-11 08:09:38 UTC) #2
alancutter (OOO until 2018)
On 2013/02/11 08:09:38, Mike West (chromium) wrote: > On 2013/02/11 02:26:09, alancutter wrote: > > ...
7 years, 10 months ago (2013-02-12 01:45:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/12207102/1
7 years, 10 months ago (2013-02-12 01:46:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=110619
7 years, 10 months ago (2013-02-12 05:45:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/12207102/1
7 years, 10 months ago (2013-02-12 06:25:16 UTC) #6
Mike West
On 2013/02/12 01:45:29, alancutter wrote: > On 2013/02/11 08:09:38, Mike West (chromium) wrote: > > ...
7 years, 10 months ago (2013-02-12 06:26:06 UTC) #7
Mike West
I have no idea what the CQ is doing here. Poking it.
7 years, 10 months ago (2013-02-12 17:15:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/12207102/1
7 years, 10 months ago (2013-02-13 19:30:51 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 02:18:56 UTC) #10
Message was sent while issue was closed.
Change committed as 182371

Powered by Google App Engine
This is Rietveld 408576698