Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 12207099: Update web-app client to use plugin notifyDeviceResolution API. (Closed)

Created:
7 years, 10 months ago by Wez
Modified:
7 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Update web-app client to use plugin notifyDeviceResolution API. BUG=172404 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181987

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -24 lines) Patch
M remoting/webapp/client_plugin.js View 2 chunks +7 lines, -5 lines 0 comments Download
M remoting/webapp/client_plugin_async.js View 1 chunk +19 lines, -10 lines 2 comments Download
M remoting/webapp/client_session.js View 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wez
PTAL. This builds on the proto and plugin CLs.
7 years, 10 months ago (2013-02-10 23:13:21 UTC) #1
Jamie
lgtm https://chromiumcodereview.appspot.com/12207099/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): https://chromiumcodereview.appspot.com/12207099/diff/1/remoting/webapp/client_plugin_async.js#newcode392 remoting/webapp/client_plugin_async.js:392: * @param {number} device_scale The number of device ...
7 years, 10 months ago (2013-02-11 20:32:02 UTC) #2
Wez
https://chromiumcodereview.appspot.com/12207099/diff/1/remoting/webapp/client_plugin_async.js File remoting/webapp/client_plugin_async.js (right): https://chromiumcodereview.appspot.com/12207099/diff/1/remoting/webapp/client_plugin_async.js#newcode392 remoting/webapp/client_plugin_async.js:392: * @param {number} device_scale The number of device pixels ...
7 years, 10 months ago (2013-02-11 23:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12207099/1
7 years, 10 months ago (2013-02-12 04:59:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98522
7 years, 10 months ago (2013-02-12 06:04:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12207099/1
7 years, 10 months ago (2013-02-12 19:04:43 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 20:03:06 UTC) #7
Message was sent while issue was closed.
Change committed as 181987

Powered by Google App Engine
This is Rietveld 408576698