Issue 12207091: Cleanup: Remove deprecated base::Value methods from dbus. Use base::Value too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12207091: Cleanup: Remove deprecated base::Value methods from dbus. Use base::Value too. (Closed)

Created:
7 years, 10 months ago by Lei Zhang

Modified:
7 years, 10 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove deprecated base::Value methods from dbus. Use base::Value too. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181989

Patch Set 1 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -71 lines)			Patch
	M	dbus/values_util.cc	View		9 chunks	+22 lines, -21 lines	0 comments	Download
	M	dbus/values_util_unittest.cc	View		12 chunks	+54 lines, -50 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207091/4

7 years, 10 months ago (2013-02-12 03:27:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98510

7 years, 10 months ago (2013-02-12 06:02:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12207091/4

7 years, 10 months ago (2013-02-12 17:17:20 UTC) #5

Message was sent while issue was closed.

Change committed as 181989

Expand Messages | Collapse Messages