Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/browser/webui/web_ui_message_handler_unittest.cc

Issue 12207089: Cleanup: Remove deprecated base::Value methods from contents. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/webui/web_ui_message_handler_unittest.cc
===================================================================
--- content/browser/webui/web_ui_message_handler_unittest.cc (revision 181443)
+++ content/browser/webui/web_ui_message_handler_unittest.cc (working copy)
@@ -18,78 +18,78 @@
string16 neg_string(UTF8ToUTF16("-1234"));
string16 pos_string(UTF8ToUTF16("1234"));
- list.Append(Value::CreateIntegerValue(zero_value));
+ list.Append(new base::FundamentalValue(zero_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, zero_value);
list.Clear();
- list.Append(Value::CreateIntegerValue(neg_value));
+ list.Append(new base::FundamentalValue(neg_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, neg_value);
list.Clear();
- list.Append(Value::CreateIntegerValue(pos_value));
+ list.Append(new base::FundamentalValue(pos_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, pos_value);
list.Clear();
- list.Append(Value::CreateStringValue(zero_string));
+ list.Append(new base::StringValue(zero_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, zero_value);
list.Clear();
- list.Append(Value::CreateStringValue(neg_string));
+ list.Append(new base::StringValue(neg_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, neg_value);
list.Clear();
- list.Append(Value::CreateStringValue(pos_string));
+ list.Append(new base::StringValue(pos_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractIntegerValue(&list, &value));
EXPECT_EQ(value, pos_value);
}
TEST(WebUIMessageHandlerTest, ExtractDoubleValue) {
- ListValue list;
+ base::ListValue list;
double value, zero_value = 0.0, neg_value = -1234.5, pos_value = 1234.5;
string16 zero_string(UTF8ToUTF16("0"));
string16 neg_string(UTF8ToUTF16("-1234.5"));
string16 pos_string(UTF8ToUTF16("1234.5"));
- list.Append(Value::CreateDoubleValue(zero_value));
+ list.Append(new base::FundamentalValue(zero_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, zero_value);
list.Clear();
- list.Append(Value::CreateDoubleValue(neg_value));
+ list.Append(new base::FundamentalValue(neg_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, neg_value);
list.Clear();
- list.Append(Value::CreateDoubleValue(pos_value));
+ list.Append(new base::FundamentalValue(pos_value));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, pos_value);
list.Clear();
- list.Append(Value::CreateStringValue(zero_string));
+ list.Append(new base::StringValue(zero_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, zero_value);
list.Clear();
- list.Append(Value::CreateStringValue(neg_string));
+ list.Append(new base::StringValue(neg_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, neg_value);
list.Clear();
- list.Append(Value::CreateStringValue(pos_string));
+ list.Append(new base::StringValue(pos_string));
EXPECT_TRUE(WebUIMessageHandler::ExtractDoubleValue(&list, &value));
EXPECT_DOUBLE_EQ(value, pos_value);
}
TEST(WebUIMessageHandlerTest, ExtractStringValue) {
- ListValue list;
+ base::ListValue list;
string16 in_string(UTF8ToUTF16(
"The facts, though interesting, are irrelevant."));
- list.Append(Value::CreateStringValue(in_string));
+ list.Append(new base::StringValue(in_string));
string16 out_string = WebUIMessageHandler::ExtractStringValue(&list);
EXPECT_EQ(in_string, out_string);
}
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698