Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 12207089: Cleanup: Remove deprecated base::Value methods from contents. Use base::Value too. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/dom_automation_controller.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 virtual void OnImeConfirmComposition( 803 virtual void OnImeConfirmComposition(
804 const string16& text, const ui::Range& replacement_range) OVERRIDE; 804 const string16& text, const ui::Range& replacement_range) OVERRIDE;
805 virtual void SetDeviceScaleFactor(float device_scale_factor) OVERRIDE; 805 virtual void SetDeviceScaleFactor(float device_scale_factor) OVERRIDE;
806 virtual ui::TextInputType GetTextInputType() OVERRIDE; 806 virtual ui::TextInputType GetTextInputType() OVERRIDE;
807 virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE; 807 virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE;
808 virtual void GetCompositionCharacterBounds( 808 virtual void GetCompositionCharacterBounds(
809 std::vector<gfx::Rect>* character_bounds) OVERRIDE; 809 std::vector<gfx::Rect>* character_bounds) OVERRIDE;
810 virtual bool CanComposeInline() OVERRIDE; 810 virtual bool CanComposeInline() OVERRIDE;
811 811
812 protected: 812 protected:
813 RenderViewImpl(RenderViewImplParams* params); 813 explicit RenderViewImpl(RenderViewImplParams* params);
814 814
815 // Do not delete directly. This class is reference counted. 815 // Do not delete directly. This class is reference counted.
816 virtual ~RenderViewImpl(); 816 virtual ~RenderViewImpl();
817 817
818 private: 818 private:
819 // For unit tests. 819 // For unit tests.
820 friend class ExternalPopupMenuTest; 820 friend class ExternalPopupMenuTest;
821 friend class PepperDeviceTest; 821 friend class PepperDeviceTest;
822 friend class RendererAccessibilityTest; 822 friend class RendererAccessibilityTest;
823 friend class WebIntentsHostTest; 823 friend class WebIntentsHostTest;
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1079 // ViewHostMsg_FrameTreeUpdated comments. If |exclude_frame_subtree| 1079 // ViewHostMsg_FrameTreeUpdated comments. If |exclude_frame_subtree|
1080 // frame is non-NULL, the subtree starting at that frame not included in the 1080 // frame is non-NULL, the subtree starting at that frame not included in the
1081 // serialized form. 1081 // serialized form.
1082 // This is used when a frame is going to be removed from the tree. 1082 // This is used when a frame is going to be removed from the tree.
1083 void SendUpdatedFrameTree(WebKit::WebFrame* exclude_frame_subtree); 1083 void SendUpdatedFrameTree(WebKit::WebFrame* exclude_frame_subtree);
1084 1084
1085 // Recursively creates a DOM frame tree starting with |frame|, based on 1085 // Recursively creates a DOM frame tree starting with |frame|, based on
1086 // |frame_tree|. For each node, the frame is navigated to the swapped out URL, 1086 // |frame_tree|. For each node, the frame is navigated to the swapped out URL,
1087 // the name (if present) is set on it, and all the subframes are created 1087 // the name (if present) is set on it, and all the subframes are created
1088 // and added to the DOM. 1088 // and added to the DOM.
1089 void CreateFrameTree(WebKit::WebFrame* frame, DictionaryValue* frame_tree); 1089 void CreateFrameTree(WebKit::WebFrame* frame,
1090 base::DictionaryValue* frame_tree);
1090 1091
1091 // If this is a swapped out RenderView, which maintains a copy of the frame 1092 // If this is a swapped out RenderView, which maintains a copy of the frame
1092 // tree of an active RenderView, we keep a map from frame ids in this view to 1093 // tree of an active RenderView, we keep a map from frame ids in this view to
1093 // the frame ids of the active view for each corresponding frame. 1094 // the frame ids of the active view for each corresponding frame.
1094 // This method returns the frame in this RenderView that corresponds to the 1095 // This method returns the frame in this RenderView that corresponds to the
1095 // frame in the active RenderView specified by |remote_frame_id|. 1096 // frame in the active RenderView specified by |remote_frame_id|.
1096 WebKit::WebFrame* GetFrameByRemoteID(int remote_frame_id); 1097 WebKit::WebFrame* GetFrameByRemoteID(int remote_frame_id);
1097 1098
1098 void EnsureMediaStreamImpl(); 1099 void EnsureMediaStreamImpl();
1099 1100
(...skipping 498 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 // use the Observer interface to filter IPC messages and receive frame change 1599 // use the Observer interface to filter IPC messages and receive frame change
1599 // notifications. 1600 // notifications.
1600 // --------------------------------------------------------------------------- 1601 // ---------------------------------------------------------------------------
1601 1602
1602 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1603 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1603 }; 1604 };
1604 1605
1605 } // namespace content 1606 } // namespace content
1606 1607
1607 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1608 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/dom_automation_controller.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698