Make DiskCacheTest.MultipleInstances pass in net_unittests on Windows 64-bit

Make DiskCacheTest.MultipleInstances pass in net_unittests on Windows 64-bit

fix length of trace buffer to cope with longer 64bit pointers

BUG=175179
R=rch@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181557

[Will Harris, 2013-02-08 19:19:35]

trivial fix to the net diskcache logging subsystem to allow logging of longer
64bit pointers

[Ryan Hamilton, 2013-02-08 19:27:53]

I suspect that your fix is right, but I'm having a hard time understanding why. 
Can you explain why 12 * sizeof(size_t) is the right thing?

https://codereview.chromium.org/12207084/diff/1/net/disk_cache/trace.cc
File net/disk_cache/trace.cc (right):

https://codereview.chromium.org/12207084/diff/1/net/disk_cache/trace.cc#newco...
net/disk_cache/trace.cc:30: const int kNumberOfEntries = 5000;  // 240 KB.
I assume this comment should be updated?

[Will Harris, 2013-02-08 19:36:05]

12 * sizeof(size_t) gives 48 on 32bit systems and 96 on 64bit systems (enough
for longer pointer strings), Justin and I felt it was safer to leave 32bit
behavior the same as before (48) in case of any weird test related assumptions
elsewhere.

[Will Harris, 2013-02-08 19:39:02]

fixed comment in patch set 3.  good spot :)

https://codereview.chromium.org/12207084/diff/1/net/disk_cache/trace.cc
File net/disk_cache/trace.cc (right):

https://codereview.chromium.org/12207084/diff/1/net/disk_cache/trace.cc#newco...
net/disk_cache/trace.cc:30: const int kNumberOfEntries = 5000;  // 240 KB.
On 2013/02/08 19:27:53, Ryan Hamilton wrote:
> I assume this comment should be updated?

Done.

[Ryan Hamilton, 2013-02-08 19:49:22]

lgtm

[commit-bot: I haz the power, 2013-02-08 19:51:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/12207084/9001

[commit-bot: I haz the power, 2013-02-08 21:45:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wfh@chromium.org/12207084/9001

[commit-bot: I haz the power, 2013-02-08 21:48:59]

Change committed as 181557