Issue 12207077: Refactored error screen logic.

Issue 12207077: Refactored error screen logic. (Closed)

Created:
7 years, 10 months ago by ygorshenin1

Modified:
7 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactored error screen logic. BUG=157627 TEST=Manual tests on Linux ChromeOS and Lumpy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181517

Patch Set 2 : Fix. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -54 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/error_screen_actor.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.css	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.html	View		1 chunk	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.js	View		5 chunks	+45 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/error_screen_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1	7 chunks	+17 lines, -30 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/12207077/diff/1/chrome/browser/chromeos/login/error_screen_actor.h File chrome/browser/chromeos/login/error_screen_actor.h (right): https://codereview.chromium.org/12207077/diff/1/chrome/browser/chromeos/login/error_screen_actor.h#newcode23 chrome/browser/chromeos/login/error_screen_actor.h:23: STATE_TIMEOUT_ERROR, nit: Please move this to the end ...

7 years, 10 months ago (2013-02-08 11:53:22 UTC) #2

ygorshenin1

https://codereview.chromium.org/12207077/diff/1/chrome/browser/chromeos/login/error_screen_actor.h File chrome/browser/chromeos/login/error_screen_actor.h (right): https://codereview.chromium.org/12207077/diff/1/chrome/browser/chromeos/login/error_screen_actor.h#newcode23 chrome/browser/chromeos/login/error_screen_actor.h:23: STATE_TIMEOUT_ERROR, On 2013/02/08 11:53:22, Nikita Kostylev wrote: > nit: ...

7 years, 10 months ago (2013-02-08 12:05:01 UTC) #3

ygorshenin1

PTAL again due to some fixes in the latest patchset.

7 years, 10 months ago (2013-02-08 12:05:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/12207077/4001

7 years, 10 months ago (2013-02-08 15:41:29 UTC) #6

Message was sent while issue was closed.

Change committed as 181517

Expand Messages | Collapse Messages