Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2663)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/google_apis/fake_drive_service_unittest.cc

Issue 12207075: Split InitiateUpload method into two. (Closed) Base URL: http://git.chromium.org/chromium/src.git@b148632_extract_initiate_upload_operation_base
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google_apis/fake_drive_service.cc ('k') | chrome/browser/google_apis/gdata_wapi_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/fake_drive_service_unittest.cc
diff --git a/chrome/browser/google_apis/fake_drive_service_unittest.cc b/chrome/browser/google_apis/fake_drive_service_unittest.cc
index 33f903669726dda5cd802d0b09e718366bd969d8..5c6354c2d334977f608405a75beced58f0047c51 100644
--- a/chrome/browser/google_apis/fake_drive_service_unittest.cc
+++ b/chrome/browser/google_apis/fake_drive_service_unittest.cc
@@ -1042,21 +1042,18 @@ TEST_F(FakeDriveServiceTest, AddNewDirectory_Offline) {
EXPECT_FALSE(resource_entry);
}
-TEST_F(FakeDriveServiceTest, InitiateUpload_Offline) {
+TEST_F(FakeDriveServiceTest, InitiateUploadNewFile_Offline) {
ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
fake_service_.set_offline(true);
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 13,
- GURL("https://1_folder_resumable_create_media_link"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
+ "test/foo",
+ 13,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1066,20 +1063,17 @@ TEST_F(FakeDriveServiceTest, InitiateUpload_Offline) {
EXPECT_TRUE(upload_location.is_empty());
}
-TEST_F(FakeDriveServiceTest, InitiateUpload_NotFound) {
+TEST_F(FakeDriveServiceTest, InitiateUploadNewFile_NotFound) {
ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 13,
- GURL("https://non_existent"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
+ "test/foo",
+ 13,
+ GURL("https://non_existent"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1089,20 +1083,17 @@ TEST_F(FakeDriveServiceTest, InitiateUpload_NotFound) {
EXPECT_TRUE(upload_location.is_empty());
}
-TEST_F(FakeDriveServiceTest, InitiateUpload_NewFile) {
+TEST_F(FakeDriveServiceTest, InitiateUploadNewFile) {
ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 13,
- GURL("https://1_folder_resumable_create_media_link"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
+ "test/foo",
+ 13,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1114,20 +1105,58 @@ TEST_F(FakeDriveServiceTest, InitiateUpload_NewFile) {
upload_location);
}
-TEST_F(FakeDriveServiceTest, InitiateUpload_WrongETag) {
+TEST_F(FakeDriveServiceTest, InitiateUploadExistingFile_Offline) {
+ ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
+ fake_service_.set_offline(true);
+
+ GDataErrorCode error = GDATA_OTHER_ERROR;
+ GURL upload_location;
+ fake_service_.InitiateUploadExistingFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
+ "test/foo",
+ 13,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "", // etag
+ base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
+ &error,
+ &upload_location));
+ message_loop_.RunUntilIdle();
+
+ EXPECT_EQ(GDATA_NO_CONNECTION, error);
+ EXPECT_TRUE(upload_location.is_empty());
+}
+
+TEST_F(FakeDriveServiceTest, InitiateUploadExistingFile_NotFound) {
+ ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
+
+ GDataErrorCode error = GDATA_OTHER_ERROR;
+ GURL upload_location;
+ fake_service_.InitiateUploadExistingFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1")),
+ "test/foo",
+ 13,
+ GURL("https://non_existent"),
+ "", // etag
+ base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
+ &error,
+ &upload_location));
+ message_loop_.RunUntilIdle();
+
+ EXPECT_EQ(HTTP_NOT_FOUND, error);
+ EXPECT_TRUE(upload_location.is_empty());
+}
+
+TEST_F(FakeDriveServiceTest, InitiateUploadExistingFile_WrongETag) {
ASSERT_TRUE(fake_service_.LoadResourceListForWapi("gdata/root_feed.json"));
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_EXISTING_FILE,
- "name_ignored",
- "text/plain",
- 13,
- GURL("https://2_file_link_resumable_create_media"),
- base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
- "invalid_etag"),
+ fake_service_.InitiateUploadExistingFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
+ "text/plain",
+ 13,
+ GURL("https://2_file_link_resumable_create_media"),
+ "invalid_etag",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1142,15 +1171,12 @@ TEST_F(FakeDriveServiceTest, InitiateUpload_ExistingFile) {
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_EXISTING_FILE,
- "name_ignored",
- "text/plain",
- 13,
- GURL("https://2_file_link_resumable_create_media"),
- base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
- "\"HhMOFgxXHit7ImBr\""),
+ fake_service_.InitiateUploadExistingFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
+ "text/plain",
+ 13,
+ GURL("https://2_file_link_resumable_create_media"),
+ "\"HhMOFgxXHit7ImBr\"",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1166,15 +1192,12 @@ TEST_F(FakeDriveServiceTest, ResumeUpload_Offline) {
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 15,
- GURL("https://1_folder_resumable_create_media_link"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
+ "test/foo",
+ 15,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1209,15 +1232,12 @@ TEST_F(FakeDriveServiceTest, ResumeUpload_NotFound) {
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 15,
- GURL("https://1_folder_resumable_create_media_link"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
+ "test/foo",
+ 15,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1247,15 +1267,12 @@ TEST_F(FakeDriveServiceTest, ResumeUpload_ExistingFile) {
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_EXISTING_FILE,
- "name_ignored",
- "text/plain",
- 15,
- GURL("https://2_file_link_resumable_create_media"),
- base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
- "\"HhMOFgxXHit7ImBr\""),
+ fake_service_.InitiateUploadExistingFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/File 1.txt")),
+ "text/plain",
+ 15,
+ GURL("https://2_file_link_resumable_create_media"),
+ "\"HhMOFgxXHit7ImBr\"",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
@@ -1301,15 +1318,12 @@ TEST_F(FakeDriveServiceTest, ResumeUpload_NewFile) {
GDataErrorCode error = GDATA_OTHER_ERROR;
GURL upload_location;
- fake_service_.InitiateUpload(
- InitiateUploadParams(
- UPLOAD_NEW_FILE,
- "new file.foo",
- "test/foo",
- 15,
- GURL("https://1_folder_resumable_create_media_link"),
- base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
- "etag_ignored"),
+ fake_service_.InitiateUploadNewFile(
+ base::FilePath(FILE_PATH_LITERAL("drive/Directory 1/new file.foo")),
+ "test/foo",
+ 15,
+ GURL("https://1_folder_resumable_create_media_link"),
+ "new file.foo",
base::Bind(&test_util::CopyResultsFromInitiateUploadCallback,
&error,
&upload_location));
« no previous file with comments | « chrome/browser/google_apis/fake_drive_service.cc ('k') | chrome/browser/google_apis/gdata_wapi_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698