Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc

Issue 12207058: Connect SparseHistogram with the rest of stats system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc b/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
index 8614d53f203bd6555002839873b517a3aa8ca04f..38977bab5353c8cc84ca860733d06b82ce3ac4e5 100644
--- a/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc
@@ -13,7 +13,7 @@
#include "base/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
-using base::Histogram;
+using base::HistogramBase;
using base::HistogramSamples;
using base::StatisticsRecorder;
@@ -37,7 +37,7 @@ class SpellcheckHostMetricsTest : public testing::Test {
TEST_F(SpellcheckHostMetricsTest, RecordEnabledStats) {
scoped_ptr<HistogramSamples> baseline;
- Histogram* histogram =
+ HistogramBase* histogram =
StatisticsRecorder::FindHistogram("SpellCheck.Enabled");
if (histogram)
baseline = histogram->SnapshotSamples();
@@ -69,7 +69,7 @@ TEST_F(SpellcheckHostMetricsTest, RecordEnabledStats) {
TEST_F(SpellcheckHostMetricsTest, CustomWordStats) {
metrics()->RecordCustomWordCountStats(123);
- Histogram* histogram =
+ HistogramBase* histogram =
StatisticsRecorder::FindHistogram("SpellCheck.CustomWords");
ASSERT_TRUE(histogram != NULL);
scoped_ptr<HistogramSamples> baseline = histogram->SnapshotSamples();
@@ -102,7 +102,7 @@ TEST_F(SpellcheckHostMetricsTest, RecordWordCountsDiscardsDuplicates) {
// Get baselines for all affected histograms.
scoped_ptr<HistogramSamples> baselines[arraysize(histogramName)];
for (size_t i = 0; i < arraysize(histogramName); ++i) {
- Histogram* histogram =
+ HistogramBase* histogram =
StatisticsRecorder::FindHistogram(histogramName[i]);
if (histogram)
baselines[i] = histogram->SnapshotSamples();
@@ -114,7 +114,7 @@ TEST_F(SpellcheckHostMetricsTest, RecordWordCountsDiscardsDuplicates) {
// Get samples for all affected histograms.
scoped_ptr<HistogramSamples> samples[arraysize(histogramName)];
for (size_t i = 0; i < arraysize(histogramName); ++i) {
- Histogram* histogram =
+ HistogramBase* histogram =
StatisticsRecorder::FindHistogram(histogramName[i]);
ASSERT_TRUE(histogram != NULL);
samples[i] = histogram->SnapshotSamples();
@@ -128,8 +128,7 @@ TEST_F(SpellcheckHostMetricsTest, RecordWordCountsDiscardsDuplicates) {
TEST_F(SpellcheckHostMetricsTest, RecordSpellingServiceStats) {
const char kMetricName[] = "SpellCheck.SpellingService.Enabled";
scoped_ptr<HistogramSamples> baseline;
- Histogram* histogram =
- StatisticsRecorder::FindHistogram(kMetricName);
+ HistogramBase* histogram = StatisticsRecorder::FindHistogram(kMetricName);
if (histogram)
baseline = histogram->SnapshotSamples();

Powered by Google App Engine
This is Rietveld 408576698