Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2276)

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_apitest.cc

Issue 12207058: Connect SparseHistogram with the rest of stats system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/metrics_private/metrics_apitest.cc
diff --git a/chrome/browser/extensions/api/metrics_private/metrics_apitest.cc b/chrome/browser/extensions/api/metrics_private/metrics_apitest.cc
index e9d5efe3d0ae21ffd99473a2196d921999bafb9e..407ddaa88807e54a6fe0b693e57057b0020cc1d6 100644
--- a/chrome/browser/extensions/api/metrics_private/metrics_apitest.cc
+++ b/chrome/browser/extensions/api/metrics_private/metrics_apitest.cc
@@ -110,13 +110,12 @@ void ValidateHistograms(const RecordedHistogram* recorded,
const RecordedHistogram& r = recorded[i];
size_t j = 0;
for (j = 0; j < histograms.size(); ++j) {
- base::Histogram* histogram(histograms[j]);
+ base::HistogramBase* histogram(histograms[j]);
if (r.name == histogram->histogram_name()) {
EXPECT_EQ(r.type, histogram->GetHistogramType());
- EXPECT_EQ(r.min, histogram->declared_min());
- EXPECT_EQ(r.max, histogram->declared_max());
- EXPECT_EQ(r.buckets, histogram->bucket_count());
+ EXPECT_TRUE(
+ histogram->HasConstructionArguments(r.min, r.max, r.buckets));
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698