Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: base/metrics/histogram_snapshot_manager.h

Issue 12207058: Connect SparseHistogram with the rest of stats system (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/metrics/histogram_flattener.h ('k') | base/metrics/histogram_snapshot_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_ 5 #ifndef BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_
6 #define BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_ 6 #define BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/metrics/histogram.h" 12 #include "base/metrics/histogram_base.h"
13 13
14 namespace base { 14 namespace base {
15 15
16 class HistogramSamples; 16 class HistogramSamples;
17 class HistogramFlattener; 17 class HistogramFlattener;
18 18
19 // HistogramSnapshotManager handles the logistics of gathering up available 19 // HistogramSnapshotManager handles the logistics of gathering up available
20 // histograms for recording either to disk or for transmission (such as from 20 // histograms for recording either to disk or for transmission (such as from
21 // renderer to browser, or from browser to UMA upload). Since histograms can sit 21 // renderer to browser, or from browser to UMA upload). Since histograms can sit
22 // in memory for an extended period of time, and are vulnerable to memory 22 // in memory for an extended period of time, and are vulnerable to memory
23 // corruption, this class also validates as much rendundancy as it can before 23 // corruption, this class also validates as much rendundancy as it can before
24 // calling for the marginal change (a.k.a., delta) in a histogram to be 24 // calling for the marginal change (a.k.a., delta) in a histogram to be
25 // recorded. 25 // recorded.
26 class BASE_EXPORT HistogramSnapshotManager { 26 class BASE_EXPORT HistogramSnapshotManager {
27 public: 27 public:
28 explicit HistogramSnapshotManager(HistogramFlattener* histogram_flattener); 28 explicit HistogramSnapshotManager(HistogramFlattener* histogram_flattener);
29 virtual ~HistogramSnapshotManager(); 29 virtual ~HistogramSnapshotManager();
30 30
31 // Snapshot all histograms, and ask |histogram_flattener_| to record the 31 // Snapshot all histograms, and ask |histogram_flattener_| to record the
32 // delta. The arguments allow selecting only a subset of histograms for 32 // delta. The arguments allow selecting only a subset of histograms for
33 // recording, or to set a flag in each recorded histogram. 33 // recording, or to set a flag in each recorded histogram.
34 void PrepareDeltas(Histogram::Flags flags_to_set, bool record_only_uma); 34 void PrepareDeltas(HistogramBase::Flags flags_to_set, bool record_only_uma);
35 35
36 private: 36 private:
37 // Snapshot this histogram, and record the delta. 37 // Snapshot this histogram, and record the delta.
38 void PrepareDelta(const Histogram& histogram); 38 void PrepareDelta(const HistogramBase& histogram);
39 39
40 // Try to detect and fix count inconsistency of logged samples. 40 // Try to detect and fix count inconsistency of logged samples.
41 void InspectLoggedSamplesInconsistency( 41 void InspectLoggedSamplesInconsistency(
42 const HistogramSamples& new_snapshot, 42 const HistogramSamples& new_snapshot,
43 HistogramSamples* logged_samples); 43 HistogramSamples* logged_samples);
44 44
45 // For histograms, track what we've already recorded (as a sample for 45 // For histograms, track what we've already recorded (as a sample for
46 // each histogram) so that we can record only the delta with the next log. 46 // each histogram) so that we can record only the delta with the next log.
47 std::map<std::string, HistogramSamples*> logged_samples_; 47 std::map<std::string, HistogramSamples*> logged_samples_;
48 48
49 // List of histograms found to be corrupt, and their problems. 49 // List of histograms found to be corrupt, and their problems.
50 std::map<std::string, int> inconsistencies_; 50 std::map<std::string, int> inconsistencies_;
51 51
52 // |histogram_flattener_| handles the logistics of recording the histogram 52 // |histogram_flattener_| handles the logistics of recording the histogram
53 // deltas. 53 // deltas.
54 HistogramFlattener* histogram_flattener_; // Weak. 54 HistogramFlattener* histogram_flattener_; // Weak.
55 55
56 DISALLOW_COPY_AND_ASSIGN(HistogramSnapshotManager); 56 DISALLOW_COPY_AND_ASSIGN(HistogramSnapshotManager);
57 }; 57 };
58 58
59 } // namespace base 59 } // namespace base
60 60
61 #endif // BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_ 61 #endif // BASE_METRICS_HISTOGRAM_SNAPSHOT_MANAGER_H_
OLDNEW
« no previous file with comments | « base/metrics/histogram_flattener.h ('k') | base/metrics/histogram_snapshot_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698