Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 12207034: Linux/ChromeOS Chromium style checker cleanup, remoting/ edition. (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi
Modified:
7 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Linux/ChromeOS Chromium style checker cleanup, remoting/ edition. Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M remoting/base/resources_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/audio_player_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_entrypoints.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/host/local_input_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/local_input_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/chromium_socket_factory.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/protocol/buffered_socket_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/channel_multiplexer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
sergeyu: Please consider rubberstamping. This is an automated fixup that was generated by our Clang ...
7 years, 10 months ago (2013-02-06 05:58:39 UTC) #1
Sergey Ulanov
lgtm
7 years, 10 months ago (2013-02-06 18:33:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12207034/1
7 years, 10 months ago (2013-02-06 18:35:47 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 22:56:52 UTC) #4
Message was sent while issue was closed.
Change committed as 181075

Powered by Google App Engine
This is Rietveld 408576698