Crash fix for calling LoginUtilsImpl::RestoreAuthSession() during the main loop shutdown.

Crash fix for calling LoginUtilsImpl::RestoreAuthSession() during the main loop shutdown.

TEST=verify that crash disappears from newer builds
BUG=174374
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180896

[xiyuan, 2013-02-05 20:20:39]

Looking at the crash, it seems to me that the crash is caused by a NULL
authentication_profile() returned from |authenticator_|.

The |authentication_profile_| is set in
ParallelAuthenticator::AuthenticateToLogin or
ParallelAuthenticator::CompleteLogin. So this looks like the case that user sits
on sign-in screen and network type change notification kicks in to trigger the
crash.

[zel, 2013-02-05 21:03:15]

On 2013/02/05 20:20:39, xiyuan wrote:
> Looking at the crash, it seems to me that the crash is caused by a NULL
> authentication_profile() returned from |authenticator_|.
> 
> The |authentication_profile_| is set in
> ParallelAuthenticator::AuthenticateToLogin or
> ParallelAuthenticator::CompleteLogin. So this looks like the case that user
sits
> on sign-in screen and network type change notification kicks in to trigger the
> crash.

Hmm, I thought we just called LoginUtilsImpl::StopBackgroundFetchers() there
instead. Let me take a look at this.

[zel, 2013-02-06 00:31:07]

PTAL

[xiyuan, 2013-02-06 00:32:17]

lgtm

[commit-bot: I haz the power, 2013-02-06 00:43:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/12207024/9002

[commit-bot: I haz the power, 2013-02-06 03:57:35]

Change committed as 180896